feat: Added client memory stats + cleaned up diagnostics prefabs #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmeyer-ms
approved these changes
May 2, 2025
frgarc
approved these changes
May 2, 2025
| )} | ||
| {tabPrefab.content({ selectedClient, selectedPlugin })} | ||
| </VSCodePanelView> | ||
| ))} |
| // Filter out data points that are older than the latest tick | ||
| newData = newData.filter(dataPoint => { | ||
| const latestTick = latestTicks.get(dataPoint.category!); | ||
| return latestTick !== undefined && dataPoint.time === latestTick; |
There was a problem hiding this comment.
Nit non-blocking, shouldn't this be enough?
Suggested change
| return latestTick !== undefined && dataPoint.time === latestTick; | |
| return dataPoint.time === latestTick; |
Comment on lines
+92
to
+102
| newData.sort((a, b) => { | ||
| if (selectedSortType === MinecraftStatisticTableSortType.Alphabetical) { | ||
| return selectedSortOrder === MinecraftStatisticTableSortOrder.Ascending | ||
| ? a.category!.localeCompare(b.category!) | ||
| : b.category!.localeCompare(a.category!); | ||
| } else { | ||
| return selectedSortOrder === MinecraftStatisticTableSortOrder.Ascending | ||
| ? a.absoluteValue - b.absoluteValue | ||
| : b.absoluteValue - a.absoluteValue; | ||
| } | ||
| }); |
There was a problem hiding this comment.
Nit non-blocking, for performance it would be better to split into 4 sort sentences, otherwise it is making the comparison of filter types in every nested iteration.
| const statsTab: TabPrefab = { | ||
| name: 'Client - Memory', | ||
| dataSource: TabPrefabDataSource.Client, | ||
| content: ({ selectedClient }: TabPrefabParams) => { |
There was a problem hiding this comment.
Non-blocking: Would be awesome to use some react memoize mechanism to the content rendering :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes two main things:
Screenshot