-
Notifications
You must be signed in to change notification settings - Fork 0
Final branch #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nielsrolf
wants to merge
35
commits into
master
Choose a base branch
from
final_branch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Final branch #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rd_data: train_test_split needs to be impemented and modelselection should adjust: it assumes batch ids and not point ids in a train test split
…kes too long bc extract rows is called every time
Use relative import without src Use relative import without src generates the data initally (1st thing to run on the cluster), then Use relative import without src Use relative import without src Use relative import without src. However at the moment we have in feature_enum.py no OPEN, so it breaks
… understand our current features and where the OPEN feature went
…e epochs are resettet and how long the training is and if the days with closed stores have effect on the val acc
…nd labels, maybe then it's easier
…h small numbers everywhere for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are described in the commit message, not sure if it works now but @Mshaban it would be awesome if you can check it, should not be so much anymore. Yesterday the code was running but the models were bad, I changed some features and normalized the data, if that has broken it it should be relatively easy to fix.
I tried on the branch spell to run it on spell.run, but there are requirement problems, spell seems cool though if the other cluster can't be used for so long (weekday/store sales average feature takes some time to calculate)