[cli] Add a mechanism to cache the chain id to the client.yaml file.
#24072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
stefan-mysten
force-pushed
the
cli-chain-id-cache
branch
from
5846592 to
b978b6c
Compare
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
approved these changes
Oct 24, 2025
There was a problem hiding this comment.
Looks good. It might be good to add some tests that (1) the value does get recached if you do a network operation even if it is already cached, and (2) that if the value is cached and you perform a non-network operation then nothing fails.
It would also be good to make sure that when we create the default config for testnet that we include the testnet chain ID
stefan-mysten
added a commit
to stefan-mysten/sui
that referenced
this pull request
Oct 27, 2025
MystenLabs#24072) This PR adds a caching of chain-id to the Sui CLI. This will be used in the new pkg-alt system. In particular, the caching will happen when one of the `client` commands will do an RPC request anyway / or execute a tx. It will not happen when any client command does not work with the RPC. For `publish` and `upgrade`, it will try first to load it from cache; if it does not exist, then it will cache it. For all other commands it will always cache it. Manual test with check on the `client.yaml` file. Tested also the updated `client.yaml` file with an old CLI to ensure backwards compatibility. --- Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a caching of chain-id to the Sui CLI. This will be used in the new pkg-alt system.
In particular, the caching will happen when one of the
clientcommands will do an RPC request anyway / or execute a tx. It will not happen when any client command does not work with the RPC.For
publishandupgrade, it will try first to load it from cache; if it does not exist, then it will cache it. For all other commands it will always cache it.Test plan
Manual test with check on the
client.yamlfile. Tested also the updatedclient.yamlfile with an old CLI to ensure backwards compatibility.Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.