Skip to content

Conversation

@lavanya3k
Copy link
Collaborator

This is a new PR for the issue #298

Description of the bug: For the Collection, OnlineResource/Description, OnlineResource/Type, or OnlineAccess/Description, pyQuARC does not flag them or flags red for Related URL Type because it pulls several URLs from View related information (See the screenshot from #304). The best way to fix this bug involves three steps.

In the rule_mapping.json - Look at the url_desc_presence_check, online_resource_type_presence_check, and online_resource_type_gcmd_check checks. Change the check_id to one_item_presence_check instead of availability_check for all these sections.
Add "RelatedUrls/Description" and "RelatedUrls/URL" along with "Collection/OnlineResources/OnlineResource/Description",
"Collection/OnlineResources/OnlineResource/URL" in the url_desc_presence_check. Repeat the checks for the remaining two sections. These changes should be uniform per the wiki page and schema to perform the URL Type and description checks.

Testing concept IDs:
G1001434969-CDDIS --format umm-g
C1000000010-CDDIS --format umm-c
C1000000044-CDDIS --format umm-c

Expected outcome:

Screenshot 2025-10-14 at 11 34 31 AM Screenshot 2025-10-14 at 11 34 18 AM

@lavanya3k lavanya3k merged commit 312869c into dev Oct 16, 2025
1 check passed
@lavanya3k
Copy link
Collaborator Author

Testing in the dev branch: The code was tested for collection and granule for the above IDs, and it works.

Expected outcome:
Collection
Screenshot 2025-10-16 at 11 01 19 AM

Granule
Screenshot 2025-10-16 at 11 02 06 AM

@lavanya3k lavanya3k mentioned this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants