[Notebook] Tornadoes 2024 Data Story #245
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Yet to do:
|
|
| @@ -0,0 +1,12173 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #2. #!pip install -q earthaccess pandas xarray fsspec requests branca pystac_client matplotlib
Would consider separating this line out into it's own code cell above, and having a comment above stating to install the following libraries if running outside of the Hub
Reply via ReviewNB
| @@ -0,0 +1,12173 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,12173 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,12173 @@ | |||
| { | |||
There was a problem hiding this comment.
Would change the first point to "Choose collection ID from STAC catalog and date for analysis"
Reply via ReviewNB
| @@ -0,0 +1,12173 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #1. # TODO: Change collection_ID and date
Saw this in a few cells, is this an internal comment? If so, would modify to something like "define collection_ID and date" for the end user. Also adjust for other cells that have this
Reply via ReviewNB
| @@ -0,0 +1,12173 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,12173 @@ | |||
| { | |||
There was a problem hiding this comment.
Similar to other visualizations in the rest of the notebook, consider adding the location to the title here
Reply via ReviewNB
| @@ -0,0 +1,12173 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,12173 @@ | |||
| { | |||
There was a problem hiding this comment.
Just my $0.02 so feel free to ignore this, but I think this would be nice to also pair with another radar product and do a slider comparison (maybe velocity since that was used in the data story and has already been used in this notebook?). I also think (whether a slider is added or not) it could be useful to add a brief explanation that debris is likely being seen here. Once again just my opinion! :)
Reply via ReviewNB
| @@ -0,0 +1,12173 @@ | |||
| { | |||
There was a problem hiding this comment.
Update the print statement here to reflect this product (seems to be copied from the correlation coefficient cell)
Reply via ReviewNB
| @@ -0,0 +1,10770 @@ | |||
| { | |||
There was a problem hiding this comment.
I know I am late to review all this, so feel free to ignore, but this represents a ton of work and I feel like having it all in one notebook makes it hard to make sense of. It seems to me that it would make more sense to have it be kind of chapters where you have the setup and then each dataset or "Example" is its own notebook. That way you could use the individual notebooks as examples of how to access a particular dataset as well.
Reply via ReviewNB
| @@ -0,0 +1,10770 @@ | |||
| { | |||
There was a problem hiding this comment.
Why are these headers called: "Example:..."? Or maybe a better question is: can you explain what you are setting out to show in the various sections of this notebook. Maybe just a sentence like: This notebook uses several different data sources to inspect the paths and short-term impacts of tornadoes.
Reply via ReviewNB
| @@ -0,0 +1,10770 @@ | |||
| { | |||
There was a problem hiding this comment.
This is kind of a meta comment on notebook style, but in general the point of a notebook is really to interleave explanation with code. So if you find yourself writing inline comments in code cells - consider splitting the cell and writing the comment in a markdown cell right above the line of code that you are explaining.
Reply via ReviewNB
| @@ -0,0 +1,10770 @@ | |||
| { | |||
There was a problem hiding this comment.
You don't need the .rstrip('/') in there. Also it would be good to use a markdown cell above this code to explain what you are doing.
Reply via ReviewNB
| @@ -0,0 +1,10770 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #2. # Colors have been predifined in veda-backend https://github.com/NASA-IMPACT/veda-backend/tree/develop/raster_api/runtime/src/cmap_data#tornadoes-colormap
This implies that the colors should be accessible via the RASTER_API is that not the case and if not - should they be?
Reply via ReviewNB
There was a problem hiding this comment.
https://openveda.cloud/api/raster/colorMaps/tornado_ef_scale
There was a problem hiding this comment.
It does list six colors but the labels would need to be applied.
| @@ -0,0 +1,10770 @@ | |||
| { | |||
There was a problem hiding this comment.
This cell in particular should definitely get split up. It is doing so many different things!
Reply via ReviewNB
5 participants
Description
This notebook shows datasets used in the 2024 tornadoes data story.
What type of example is this?
Data Story
Checklist
The following checklist ensures that our notebooks are internally consistent (read more)
<collection_id>.ipynb