-
Notifications
You must be signed in to change notification settings - Fork 43
Conditionally destroy process group at end of train #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test 10b69ee |
|
/ok to test a0512a2 |
a0512a2 to
3aac03f
Compare
|
/ok to test 3aac03f |
Signed-off-by: Ananth Subramaniam <[email protected]>
Signed-off-by: Ananth Subramaniam <[email protected]>
Signed-off-by: Ananth Subramaniam <[email protected]>
Signed-off-by: Ananth Subramaniam <[email protected]>
bb4757e to
e2f2a60
Compare
|
/ok to test e2f2a60 |
paul-gibbons
pushed a commit
to paul-gibbons/Megatron-Bridge
that referenced
this pull request
Oct 29, 2025
* cleanup process group at end of train Signed-off-by: Ananth Subramaniam <[email protected]> * barrier Signed-off-by: Ananth Subramaniam <[email protected]> * self-contained within pretrain Signed-off-by: Ananth Subramaniam <[email protected]> --------- Signed-off-by: Ananth Subramaniam <[email protected]> Signed-off-by: Paul Gibbons <[email protected]>
nv-mollys
pushed a commit
that referenced
this pull request
Oct 31, 2025
* cleanup process group at end of train Signed-off-by: Ananth Subramaniam <[email protected]> * barrier Signed-off-by: Ananth Subramaniam <[email protected]> * self-contained within pretrain Signed-off-by: Ananth Subramaniam <[email protected]> --------- Signed-off-by: Ananth Subramaniam <[email protected]> Signed-off-by: mollys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #794