[sync] Fix bug in param_norm computation where some ranks might call collective and some might not #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test 815439f |
maanug-nv
approved these changes
Oct 3, 2025
Signed-off-by: Ananth Subramaniam <[email protected]>
Signed-off-by: Ananth Subramaniam <[email protected]>
Signed-off-by: Ananth Subramaniam <[email protected]>
|
/ok to test d8e2d1d |
paul-gibbons
pushed a commit
to paul-gibbons/Megatron-Bridge
that referenced
this pull request
Oct 29, 2025
…collective and some might not (NVIDIA-NeMo#852) * sync with mr 3918 Signed-off-by: Ananth Subramaniam <[email protected]> * add unit tests Signed-off-by: Ananth Subramaniam <[email protected]> * rebase Signed-off-by: Ananth Subramaniam <[email protected]> --------- Signed-off-by: Ananth Subramaniam <[email protected]> Signed-off-by: Paul Gibbons <[email protected]>
nv-mollys
pushed a commit
that referenced
this pull request
Oct 31, 2025
…collective and some might not (#852) * sync with mr 3918 Signed-off-by: Ananth Subramaniam <[email protected]> * add unit tests Signed-off-by: Ananth Subramaniam <[email protected]> * rebase Signed-off-by: Ananth Subramaniam <[email protected]> --------- Signed-off-by: Ananth Subramaniam <[email protected]> Signed-off-by: mollys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVIDIA/Megatron-LM@90f39a3