-
Couldn't load subscription status.
- Fork 162
Tk/slurm bisect #1223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
terrykong
wants to merge
12
commits into
main
Choose a base branch
from
tk/slurm-bisect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Tk/slurm bisect #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
add passing foobar Signed-off-by: Terry Kong <[email protected]> add bisect Signed-off-by: Terry Kong <[email protected]> add better error Signed-off-by: Terry Kong <[email protected]> some error messagin Signed-off-by: Terry Kong <[email protected]> try -- Signed-off-by: Terry Kong <[email protected]> ok try this Signed-off-by: Terry Kong <[email protected]> try visualize Signed-off-by: Terry Kong <[email protected]> could you try this Signed-off-by: Terry Kong <[email protected]> 2==2 Signed-off-by: Terry Kong <[email protected]> 3==4 Signed-off-by: Terry Kong <[email protected]> 3==4 (n=5) Signed-off-by: Terry Kong <[email protected]> 3==4 (n=8) Signed-off-by: Terry Kong <[email protected]> try echo Signed-off-by: Terry Kong <[email protected]> go Signed-off-by: Terry Kong <[email protected]> ok Signed-off-by: Terry Kong <[email protected]> copywrite bisect Signed-off-by: Terry Kong <[email protected]> get rid of foobar test Signed-off-by: Terry Kong <[email protected]> fix Signed-off-by: Terry Kong <[email protected]> coderabbit Signed-off-by: Terry Kong <[email protected]> slurm bisect changes Signed-off-by: Terry Kong <[email protected]> comment fix Signed-off-by: Terry Kong <[email protected]> fix Signed-off-by: Terry Kong <[email protected]> more info Signed-off-by: Terry Kong <[email protected]> submodules Signed-off-by: Terry Kong <[email protected]> add a check to see if submodule dirty and also clean the submodules after the GOOD commit check Signed-off-by: Terry Kong <[email protected]> account for NRL_MEGATRON_CHECKPOINT_DIR Signed-off-by: Terry Kong <[email protected]> chose a better dir location Signed-off-by: Terry Kong <[email protected]> switch to an explicit test case Signed-off-by: Terry Kong <[email protected]> add sed clause stuff Signed-off-by: Terry Kong <[email protected]> fix all logs glob Signed-off-by: Terry Kong <[email protected]> allow replay log Signed-off-by: Terry Kong <[email protected]> set bad commit to not head Signed-off-by: Terry Kong <[email protected]> put the mcore ckpt dir inside the experiment dir Signed-off-by: Terry Kong <[email protected]> fix up submodule reset within bisect Signed-off-by: Terry Kong <[email protected]> EXTRA_SCRIPT_ARGS Signed-off-by: Terry Kong <[email protected]> make check metrics standalone Signed-off-by: Terry Kong <[email protected]> check metrics docstring Signed-off-by: Terry Kong <[email protected]> add stuff Signed-off-by: Terry Kong <[email protected]>
89a0b31 to
6c79364
Compare
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
commits aren't found Signed-off-by: Terry Kong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1215 to enable bisecting nightly tests.
example 1 sft failures
Here's an example invocation that found one regression with
tests/test_suites/llm/sft-llama3.2-1b-1n8g-fsdp2tp1.v3.shhttps://wandb.ai/nvidia/nemo-rl?nw=fnhia71y43d
Which produces this
git bisect logwhich turned out to be a regression because the metric check was too noisy. In particular
'data["train/loss"]["250"] < 0.5' \failed once we started usingnum_workers=1which changed the determinism of the run.example 2 (fp8 bisect)
found that even the initial commit failed