Skip to content

Add reservation_config support to LeptonExecutor #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add reservation_config support to LeptonExecutor #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nemo_run/core/execution/lepton.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ class LeptonExecutor(Executor):
lepton_job_dir: str = field(init=False, default="")
custom_spec: dict[str, Any] = field(default_factory=dict)
pre_launch_commands: list[str] = field(default_factory=list) # Custom commands before launch
reservation_config: Optional[dict[str, Any]] = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be of type str instead of dict? Looking at the Lepton API it appears it just uses string.


def stop_job(self, job_id: str):
"""
Expand Down Expand Up @@ -232,7 +233,7 @@ def create_lepton_job(self, name: str):
log=None,
queue_config=None,
stopped=None,
reservation_config=None,
reservation_config=self.reservation_config,
)
job = LeptonJob(spec=job_spec, metadata=Metadata(id=name))

Expand Down
Loading