Fix a bug in Python run, run_async, sample_async, and observe_async: callable args are dropped
#3545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
1tnguyen
changed the title
cudaq.run: callable args are droppedrun, run_async, sample_async, and observe_async: callable args are dropped
Signed-off-by: Thien Nguyen <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
sacpis
reviewed
Oct 24, 2025
| prep_1_state, | ||
| num_qubits, | ||
| shots_count=10).get() | ||
| print("Results for prep_1_state with", num_qubits, "qubits:", results) |
There was a problem hiding this comment.
Do we need this print statement?
sacpis
approved these changes
Oct 24, 2025
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
previously requested changes
Oct 24, 2025
schweitzpgi
reviewed
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Python's
run,run_async,sample_async, andobserve_asyncare handled entirely in PyBinding, which is different fromsampleandobserve(Python implementation insample.pyandobserve.py.(Thanks @khalatepradnya, for pointing out all the places where we may have this oversight)
The main difference is that we're missing some logic in handling callable arguments, which is part of Python's
__call__before invokingpyAltLaunchKernel. Hence, callableargsare not packed.This PR fixes that and adds tests for this scenario.