Skip to content

fix: App::version() not returning the correct version #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2025
Merged

fix: App::version() not returning the correct version #208

merged 2 commits into from
Apr 7, 2025

Conversation

SRWieZ
Copy link
Member

@SRWieZ SRWieZ commented Apr 7, 2025

From electron code comment:

getVersion(): string; The version of the loaded application. If no version is found in the application's package.json file, the version of the current bundle or executable is returned.

@SRWieZ
Copy link
Member Author

SRWieZ commented Apr 7, 2025

Hmm, I think it still works in production.

But not with native:serve. Sooo.. a smaller fix than I thought, but still a fix.

@simonhamp simonhamp merged commit e0624eb into main Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonhamp simonhamp simonhamp approved these changes

@PeteBishwhip PeteBishwhip PeteBishwhip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SRWieZ @simonhamp @PeteBishwhip