-
-
Notifications
You must be signed in to change notification settings - Fork 95
Better webPreferences defaults #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ivePHP/electron into enhancement/disable-node-integration
Additionally I've deleted the preload file at We're only using the one from the electron plugin, so the one I removed was probably an artifact. Everything is still working as expected in my testing environment. Can someone confirm this is okay? I've checked high and low but that second preload wasn't doing anything at all. |
Co-authored-by: @JulianGlueck
…ivePHP/electron into enhancement/disable-node-integration
I've locked While working on this I noticed we couldn't pass custom webPreferences to MenuBar windows. I've added this in NativePHP/laravel#694 |
Closes NativePHP/laravel#688 |
This PR improves the default security preferences & changes
preload.js
to support those changes:native:init
event for registering Native listeners (prevents race conditions where preload hasn't evaluated yet)preload
,contextIsolation
andsandbox
cannot be changed)See NativePHP/laravel#688 for more details
This PR also introduces a event that's called whenever the
preload
script is fully evaluated. In the past some people have reported race conditions where they register a listener withNative.on()
but the Native object is not available yet.This event adresses that: