Skip to content

Make it possible to use window as the scroll element #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make it possible to use window as the scroll element #73

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddf426a
Make getting and setting of scroll position overrideable
Jul 21, 2016
9d2454a
Add scroll getter, setter to config param list
Jul 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions clusterize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,18 @@
no_data_text: 'No data',
keep_parity: true,
callbacks: {},
scroll_top: 0
scroll_top: 0,
scroll_top_getter: function() {
return self.scroll_elem.scrollTop;
},
scroll_top_setter: function(amt) {
self.scroll_elem.scrollTop = amt;
}
}

// public parameters
self.options = {};
var options = ['rows_in_block', 'blocks_in_cluster', 'show_no_data_row', 'no_data_class', 'no_data_text', 'keep_parity', 'tag', 'callbacks'];
var options = ['rows_in_block', 'blocks_in_cluster', 'show_no_data_row', 'no_data_class', 'no_data_text', 'keep_parity', 'tag', 'callbacks', 'scroll_top_getter', 'scroll_top_setter'];
for(var i = 0, option; option = options[i]; i++) {
self.options[option] = typeof data[option] != 'undefined' && data[option] != null
? data[option]
Expand All @@ -70,7 +76,7 @@
? data.rows
: self.fetchMarkup(),
cache = {data: '', bottom: 0},
scroll_top = self.scroll_elem.scrollTop;
scroll_top = self.options.scroll_top_getter();

// get row height
self.exploreEnvironment(rows);
Expand All @@ -79,7 +85,7 @@
self.insertToDOM(rows, cache);

// restore the scroll position
self.scroll_elem.scrollTop = scroll_top;
self.options.scroll_top_setter(scroll_top);

// adding scroll handler
var last_cluster = false,
Expand Down Expand Up @@ -122,14 +128,14 @@
rows = isArray(new_rows)
? new_rows
: [];
var scroll_top = self.scroll_elem.scrollTop;
var scroll_top = self.options.scroll_top_getter();
// fixes #39
if(rows.length * self.options.item_height < scroll_top) {
self.scroll_elem.scrollTop = 0;
self.options.scroll_top_setter(0);
last_cluster = 0;
}
self.insertToDOM(rows, cache);
self.scroll_elem.scrollTop = scroll_top;
self.options.scroll_top_setter(scroll_top);
}
self.clear = function() {
self.update([]);
Expand Down Expand Up @@ -196,7 +202,7 @@
},
// get current cluster number
getClusterNum: function () {
this.options.scroll_top = this.scroll_elem.scrollTop;
this.options.scroll_top = this.options.scroll_top_getter();
return Math.floor(this.options.scroll_top / (this.options.cluster_height - this.options.block_height)) || 0;
},
// generate empty row if no data provided
Expand Down