Remove macbeth chart watermark #97
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Macbeth chart watermark
Summary
The watermark added on Macbeth chart was causing
MacBethSample._sample_patchfailure.During analyse process, OpenVPCal process kept raising error:
This was coming from the call chain:
run_analyse()callsself.analyse(led_walls)analyse()creates Processing object and callsprocessing.run_sampling()MacBethSample._sample_patch()callsnp.mean(np.array(samples), axis=0)After further investigation, I found that the watermark was causing
detect_colour_checkers_segmentationfailure. Please see the reference image bellow that was generated bydetect_colour_checkers_segmentation(show=True).Reference 1
Reference 2
Old Macbeth Chart without watermark