Skip to content

Conversation

@DevTGHa
Copy link
Collaborator

@DevTGHa DevTGHa commented Oct 12, 2025

Remove Macbeth chart watermark

Summary

The watermark added on Macbeth chart was causing MacBethSample._sample_patch failure.

During analyse process, OpenVPCal process kept raising error:

Lib\site-packages\numpy\_core\fromnumeric.py:3860: RuntimeWarning: Mean of empty slice.

This was coming from the call chain:

  1. main_window.py: run_analyse() calls self.analyse(led_walls)
  2. application_base.py: analyse() creates Processing object and calls
    processing.run_sampling()
  3. sample_patch.py: MacBethSample._sample_patch() calls np.mean(np.array(samples), axis=0)

After further investigation, I found that the watermark was causing detect_colour_checkers_segmentation failure. Please see the reference image bellow that was generated by detect_colour_checkers_segmentation(show=True).

Reference 1

image

Reference 2

image

Old Macbeth Chart without watermark

OpenVPCal\tests\test_open_vp_cal\resources\RED_WhiteBalance_Test

image

removing macbeth chart because it was causing MacBethSample to fail sample patch
@DevTGHa DevTGHa requested a review from davisadam10 October 12, 2025 12:31
@DevTGHa DevTGHa self-assigned this Oct 12, 2025
@DevTGHa DevTGHa added the bug Something isn't working label Oct 12, 2025
@DevTGHa
Copy link
Collaborator Author

DevTGHa commented Oct 13, 2025

@davisadam10 I was wondering if you are happy to have this change?
If so, I can try to update the test to reflect removed watermark from the Macbeth chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants