Fix/aws secrets manager through container #2618
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savingoyal
reviewed
Sep 25, 2025
| SecretSpec.secret_spec_from_str(secret_spec_str_or_dict, role=role) | ||
| ) | ||
| elif isinstance(secret_spec_str_or_dict, dict): | ||
| # If the dict is an ECS-style container-start secret spec, skip runtime fetching. |
There was a problem hiding this comment.
this would break workloads running on EKS
There was a problem hiding this comment.
Hi @savingoyal, just checking if this works?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the secrets decorator injects the secrets into an AWS Batch job after the container has been set up. However, there may be times when secrets are necessary at the container setup entrypoint. This PR allows a user to specify a name and secrets ARN so that these can be passed into the job configuration at construction time in the form of
{"name": NAME, "value_from": SECRETS_ARN}, so that the right fields can be set like in the AWS documentation.