Unified adjustment solver for MoistStaticEnergyState and PotentialTemperatureState + atmos bomex case #124
Conversation
|
Idea: move the scripts which are supposed to be "validation" proper (i.e. testing correctness, etc.) to a |
Yes let's! Possibly, we can just convert the bomex case to an example and remove the Validation workflow (at least for now). We can reinstate the validation workflow in the future. Possibly, we want to combine "validation" and "regression" (eg the regression tests will just run cases that we have used for validation, which are the highest priority cases that we want to ensure keep working exactly as designed). |
glwagner
changed the title
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
| qˡ = q.liquid | ||
| qⁱ = q.ice | ||
|
|
||
| @inbounds energy_density[i, j, k] = ρᵣ * (cᵖᵐ * T + g * z - ℒˡᵣ * qˡ - ℒⁱᵣ * qⁱ) |
There was a problem hiding this comment.
Deduct latent heat here??
There was a problem hiding this comment.
Yes, this is a specific form of the moist static energy... we don't have a derivation of it in the docs yet but I believe it is correct. Similar to the idea of the liquid-ice potential temperature, the more liquid or ice is present, the higher T is
| Gⁿ = model.timestepper.Gⁿ | ||
| Gⁿ = model.timestepper.Gⁿ | ||
| arch = model.architecture |
There was a problem hiding this comment.
You're converting to Runic style already? 👀
This PR unifies the saturation adjustment solver for the two thermodynamic states we support:
MoistStaticEnergyStateandPotentialTemperatureState. This is useful, because we now correctly set initial conditions inAtmosphereModelbased on potential temperature input. This PR also fixesset!, which was wrong for moist initial states, and sets up an anelastic bomex case. I think we should work on actually running / validating the bomex case in a future PR.