-
Notifications
You must be signed in to change notification settings - Fork 4
Add computation of averages for subsidence forcing to Bomex example #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
examples/bomex.jl
Outdated
| Fu_subsidence = Forcing(u_subsidence, discrete_form=true, parameters=(u_avg=u_avg_f; wˢ)) | ||
| Fv_subsidence = Forcing(v_subsidence, discrete_form=true, parameters=(v_avg=u_avg_f; wˢ)) | ||
| Fθ_subsidence = Forcing(θ_subsidence, discrete_form=true, parameters=(θ_avg=u_avg_f; wˢ)) | ||
| Fq_subsidence = Forcing(q_subsidence, discrete_form=true, parameters=(q_avg=u_avg_f; wˢ)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fu_subsidence = Forcing(u_subsidence, discrete_form=true, parameters=(;u_avg=u_avg_f, wˢ))
Fv_subsidence = Forcing(v_subsidence, discrete_form=true, parameters=(;v_avg=v_avg_f, wˢ))
Fθ_subsidence = Forcing(θ_subsidence, discrete_form=true, parameters=(;θ_avg=θ_avg_f, wˢ))
Fq_subsidence = Forcing(q_subsidence, discrete_form=true, parameters=(;q_avg=q_avg_f, wˢ))
Found I needed to change the syntax of parameters (otherwise I got an error along the lines of
ERROR: LoadError: type Field has no field wˢ
Also q_avg=u_avg_f is a good way to make lots of clouds!! haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
does this PR supersedes #15? |
|
Looks good to me; @mmr0 can you have another look? |
|
This runs on GPU. This is zeros: julia> qˡt = FieldTimeSeries("bomex.jld2", "qˡ")
128×128×150×61 FieldTimeSeries{InMemory} located at (Center, Center, Center) of qˡ at bomex.jld2
├── grid: 128×128×150 RectilinearGrid{Float64, Periodic, Periodic, Bounded} on CPU with 3×3×3 halo
├── indices: (:, :, :)
├── time_indexing: Linear()
├── backend: InMemory()
├── path: bomex.jld2
├── name: qˡ
└── data: 134×134×156×61 OffsetArray(::Array{Float64, 4}, -2:131, -2:131, -2:153, 1:61) with eltype Float64 with indices -2:131×-2:131×-2:153×1:61
└── max=0.0, min=0.0, mean=0.0Is this part of the issue the PR is trying to address? |
|
Bomex should have cloud liquid. However, lack of cloud formation may be due to multiple factors. Therefore, this PR just implements one step towards a correct bomex. This PR does not aim to validate bomex. It should be merged if possible so that work can continue on validation. |
|
Let's merge then and continue! |
@mmr0 this PR shows how you can add a computation of the averages as a callback to complete the subsidence forcing.