Skip to content

[16.0][BACKPORT] project_task_tag: Migration to 16.0 #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][BACKPORT] project_task_tag: Migration to 16.0 #1512

wants to merge 6 commits into from

Conversation

maisim
Copy link

@maisim maisim commented May 27, 2025 •
edited
Loading

coleste
coleste approved these changes Jun 2, 2025
View reviewed changes
Copy link

@coleste coleste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no changes

@leemannd
Copy link
Contributor

leemannd commented Jun 3, 2025

Hello, this is a duplicate of #1159
A review on the original PR would have it merged.

dreispt
dreispt requested changes Jun 3, 2025
View reviewed changes
Copy link
Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this is NOT a migration, but a new 16.0 module, also proposed at #1159?
And it includes a commit for 17.0 migration ... but it target 16.0...
Very confusing.
It needs clarification.

@maisim maisim changed the title [16.0][MIG] project_task_tag: Migration to 16.0 [16.0][BACKPORT] project_task_tag: Migration to 16.0 Jun 3, 2025
@maisim
Copy link
Author

maisim commented Jun 3, 2025

It seems that this is NOT a migration, but a new 16.0 module, also proposed at #1159? And it includes a commit for 17.0 migration ... but it target 16.0... Very confusing. It needs clarification.

Hi @dreispt
It is a backport from 17.0 https://github.com/OCA/project/tree/17.0/project_task_tag
I hadn't seen the other PR, though, it would be a bit odd to have 2 modules with the same name in 2 different branches that aren't iso. We sould look deeper at #1159 before to choose to merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreispt dreispt dreispt requested changes

+1 more reviewer

@coleste coleste coleste approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@maisim @leemannd @dreispt @coleste @OCA-git-bot @ajaniszewska-dev @nguyenminhchien @mymage