Skip to content

[FIX] project_analytic_code: fix tests #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 17.0
Choose a base branch
from
Open

[FIX] project_analytic_code: fix tests #1517

wants to merge 4 commits into from
+747 −0

Conversation

dreispt
Copy link
Member

@dreispt dreispt commented Jun 2, 2025 •
edited
Loading

Supersedes #1438

petrus-v and others added 3 commits June 2, 2025 15:57
@petrus-v @grindtildeath @dreispt
[ADD] 14.0 new module project_analytic_code
be7f183 
This module add related Analytic account code in project
name () and you can search projects by the analytic account
code () from any list (like in timesheets).

Apply suggestions from code review

Co-authored-by: Akim Juillerat <[email protected]>
@petrus-v @dreispt
[IMP] project_analytic_code: pre-commit auto fixes
08e00a6
@petrus-v @dreispt
[MIG] project_analytic_code: Migration to 17.0
ad29b91
@dreispt dreispt changed the title petrus v 17.0 mig project analytic code [FIX] project_analytic_code: fix tests Jun 2, 2025
@dreispt dreispt requested a review from petrus-v June 2, 2025 15:02
@dreispt
Copy link
Member Author

dreispt commented Jun 2, 2025

Testes are failing. Superseded by #1517

@dreispt dreispt force-pushed the petrus-v-17.0-mig-project_analytic_code branch from 17e5696 to 6746980 Compare June 2, 2025 15:05
@dreispt dreispt force-pushed the petrus-v-17.0-mig-project_analytic_code branch from 6746980 to 2acef46 Compare June 2, 2025 15:13
@petrus-v
Copy link
Contributor

petrus-v commented Jun 2, 2025 •
edited
Loading

Hi @dreispt !

Thanks for taking care of conflict.

Just to let you know that in v14 project_sequence is declared as rebel module (cf rebel_module_groups in .copier-answers.yml, the former PR has been done 10 days before project_sequence was merged, maybe the solution is to declare it in the same way ?

There is probably a conflict as far I remember !

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 5, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 5, 2025
@petrus-v
Copy link
Contributor

petrus-v commented Oct 5, 2025

I've rebase the former PR #1438 and manage the conflict by declaring some rebel modules, I think we can close this one !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrus-v petrus-v Awaiting requested review from petrus-v

Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dreispt @petrus-v