Skip to content

[16.0][FEAT]portal: show task only if follower #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][FEAT]portal: show task only if follower #1522

wants to merge 1 commit into from

Conversation

quirino95
Copy link

This module changes behavior of task visibility: portal users now will only see task where they are explicitly set as follower, so visibility on project only is no longer enough.
However, when creating a new task, all users following the project will automatically follow the new task too.

aleuffre
aleuffre suggested changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For adding a new module, the commit message should be

[ADD] project_portal_task_visibility: show task only to followers

@aleuffre
Copy link
Contributor

Tests are failing because of incompatibility with project_task_code_portal. There are a few ways we could possibly address it, none of them are very elegant.

One of them could be to change the setup of the tests of project_task_code_portal to activate the rule again just in case. (with a comment describing why)

@quirino95 quirino95 force-pushed the portal_task_visibility branch from a82f683 to 6035b02 Compare June 10, 2025 14:57
@quirino95
Copy link
Author

Tests are failing because of incompatibility with project_task_code_portal. There are a few ways we could possibly address it, none of them are very elegant.

One of them could be to change the setup of the tests of project_task_code_portal to activate the rule again just in case. (with a comment describing why)

Forced the rule to active in setUpClass method, now tests are ok

@quirino95 quirino95 force-pushed the portal_task_visibility branch from 6035b02 to 27b3666 Compare June 10, 2025 15:07
aleuffre
aleuffre approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formal requirement, but LGTM

project_portal_task_visibility/security/project_portal_task_visibility.xml
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="utf-8" ?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: file name should be project_task_security.xml

@quirino95 quirino95 force-pushed the portal_task_visibility branch from 27b3666 to c317cbe Compare June 11, 2025 09:33
aleuffre
aleuffre approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aleuffre aleuffre aleuffre approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quirino95 @aleuffre