Skip to content

Conversation

@etobella
Copy link
Member

@etobella etobella commented Oct 5, 2025

Migration to 19.0.

Added some code on the tests in order to load demo data.

Jairo Llopis and others added 30 commits October 5, 2025 15:02
Almost any XML must start with this. Let's make it easier.
Any report inheriting this AbstractModel can check its XML results
against any XSD.
Previous instructions were misleading
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-12.0/reporting-engine-12.0-report_xml
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xml/
oca-ci and others added 6 commits October 5, 2025 15:02
Currently translated at 100.0% (16 of 16 strings)

Translation: reporting-engine-18.0/reporting-engine-18.0-report_xml
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-report_xml/it/
* report_py3o, report_xlsx, report_xml

odoo core introduced an additional argument in [1] to the method
inherited by report_py3o, report_xlsx, report_xml.
When the same method is inherited in other addons,
it raises a "TypeError: ... takes X positional arguments
but Y were given" due to a mismatch in the argument count.

This commit updates the mentioned method signature to match the
latest odoo core definition, ensuring compatibility and preventing
runtime errors when multiple addons override the same function.

No functional changes are introduced. Only method signatures have
been synchronized with upstream Odoo
Currently translated at 100.0% (16 of 16 strings)

Translation: reporting-engine-18.0/reporting-engine-18.0-report_xml
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-report_xml/tr/
@pedrobaeza
Copy link
Member

/ocabot migration report_xml

Please remind me one more time what this layer provides against putting a QWeb template with the XML header and content like Odoo does for Factur-X and others (example: https://github.com/odoo/odoo/blob/19.0/addons/account_edi_ubl_cii/data/cii_22_templates.xml)

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Oct 6, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 6, 2025
20 tasks
@etobella
Copy link
Member Author

etobella commented Oct 6, 2025

It allows to generate a report that delivers an XML file directly. Otherwise, Odoo will send you back an HTML (with xml format, but an HTML) or PDF.

@pedrobaeza
Copy link
Member

Let's include that in CONTEXT.md for later references.

@etobella etobella force-pushed the 19.0-mig-report_xml branch from 494a6e1 to 9a081cd Compare October 6, 2025 17:01
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't put lxml as external_dependencies. It's already a dependency of Odoo core.

@etobella etobella force-pushed the 19.0-mig-report_xml branch from 9a081cd to acd45cc Compare October 6, 2025 18:18
Copy link

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "Demo xml report" listed? It doesn't appears.

image

@etobella
Copy link
Member Author

etobella commented Oct 27, 2025

with the new default value of demo, demo is not imported by default.

Copy link

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 19.0-ocabot-merge-pr-1072-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ee72b6d into OCA:19.0 Oct 29, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d8c5d91. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.