-
Notifications
You must be signed in to change notification settings - Fork 627
[DE] Major rework of HassLightSet #3294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hecktech27
wants to merge
8
commits into
OHF-Voice:main
Choose a base branch
from
hecktech27:hecktech_light_set
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0fbc6c7
major changes to HassLightSet
hecktech27 b6c42a7
remove comments
hecktech27 5ad128a
remove more comments
hecktech27 a015aac
Merge branch 'OHF-Voice:main' into hecktech_light_set
hecktech27 fe6d925
Merge branch 'OHF-Voice:main' into hecktech_light_set
hecktech27 59112dd
Merge branch 'OHF-Voice:main' into hecktech_light_set
hecktech27 92d3044
Merge branch 'OHF-Voice:main' into hecktech_light_set
hecktech27 467131c
Merge branch 'main' into hecktech_light_set
andreasbrett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why only these 2 options and not the full set from <brightness_level>?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my intention for this one was to use it in a context like
and since brightness_level would then allow
i decided to use a smaller set of words for this special purpose...
But maybe i already have a better idea - i will add "Stufe" to the list from 'brightness_level' where needed. This will allow us to use all variations from brightness_level but without the unnecessary permutations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3314
the new version got a little longer but covers all useful variations from
{brightness_level}in the intended context.