[FR] add media player relative volume setting #3480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FraBoCH
changed the title
jlpouffier
requested changes
Oct 23, 2025
There was a problem hiding this comment.
Hello !
Thx a lot for your PR!
We have common expansion rules for verbs monte and baisse here
Do you mind using them so that the sentences are coherent with other sentences using these verbs?
You can take inspiration from the Absolute Volume setting in case you want to know how to use expansion rules!
|
Thanks for your review @jlpouffier! I reused the existing expansion as requested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding French sentences for HassSetVolumeRelative intent