-
Couldn't load subscription status.
- Fork 22
Fix pagination accessibility issue #3737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…om/ONSdigital/design-system into fix/pagination-accessibility-issue
|
It looks like we do have some svgs in the icon macro that return an svg that doesn't have |
I have aria-hidden=true for all the icons which doesn't have aria labelled by. Let me if that's okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
What is the context of this PR?
ONSDESYS-472
As per the ticket:
Removed "Go to" from "aria-label" attributes.
When "aria-current" is set to true a default "aria-label" will only have the text set in position variable which is
"Page " ~ currentPageIndex ~ " of " ~ totalPages(Eg When aria-current is over the 3rd page, voice over only readsPage 3 of 4instead of previousCurrent Page(Page 3 of 4))The ticket also mentions about adding "aria-hidden" to svg icons. We have this already so we don't need to make any changes to it
Also user who raised this issue used total validator to check the issue. As total validator works with a paid tier. I've used wave to test the page.
How to review this PR
Checklist
This needs to be completed by the person raising the PR.