Skip to content

Conversation

@rmccar
Copy link
Contributor

@rmccar rmccar commented Sep 26, 2025

What is the context of this PR?

This PR is to revert a change that was added to #3729. This change updated the version in the package.json. This seems to have caused the version to be wrong when downloading the package from npm and is resulting in the website using that version to use the wrong version of the CSS and JS from the CDN.

I have decided to revert this change for now in this instance. But in future they maybe something to consider keeping up to date.

How to review this PR

DS works and builds as expected

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@rmccar rmccar requested a review from a team as a code owner September 26, 2025 09:56
@netlify
Copy link

netlify bot commented Sep 26, 2025

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit e61ec22
🔍 Latest deploy log https://app.netlify.com/projects/ons-design-system-preview/deploys/68dbe8c9676660000863f9c9
😎 Deploy Preview https://deploy-preview-3738--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rmccar rmccar added the Dependencies Pull requests that update a dependency file label Sep 26, 2025
@rmccar rmccar self-assigned this Sep 26, 2025
@rmccar rmccar merged commit 83a9a22 into main Sep 30, 2025
14 checks passed
@rmccar rmccar deleted the revert-version-change branch September 30, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants