Replaces asserts with error handling in GeometryTools #13023
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces assertions with more robust error handling in GeometryTools functions. This prevents unexpected program termination due to assertion failures, especially when dealing with potentially invalid or unexpected input data. Specifically, it adds checks for null pointers and invalid indices, returning early or using fallback values to maintain program stability.
kriben
requested changes
Oct 15, 2025
| Vec3Type s; | ||
| if ( polygon.empty() ) | ||
| { | ||
| return Vec3Type::ZERO; |
There was a problem hiding this comment.
ZERO is not a good choice here, as it also a valid value. Vec3Type::UNDEFINED is better?
There was a problem hiding this comment.
Not sure that is wrong to assert here either, if it is a programmer error?
| { | ||
| CVF_ASSERT( polygon ); | ||
| CVF_ASSERT( createdVertexes ); | ||
| if ( !polygon || !createdVertexes ) return false; |
There was a problem hiding this comment.
Assert was only needed because the original api was wrong.
| double tolerance ) | ||
| { | ||
| CVF_ASSERT( polygon ); | ||
| if ( !polygon ) return false; |
There was a problem hiding this comment.
Bad api: polygon should be a reference since it is always needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13022