- 
                Notifications
    
You must be signed in to change notification settings  - Fork 38
 
Added the feature to read DICOM images into a 4D Nifti image #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            jph6366
  wants to merge
  32
  commits into
  OSIPI:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
jph6366:dicom2niix
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from 26 commits
      Commits
    
    
            Show all changes
          
          
            32 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      4bc40f2
              
                Added the feature to read DICOM images into a 4D Nifti image utilizin…
              
              
                jph6366 1e060cd
              
                Update README.md
              
              
                jph6366 a4ce220
              
                [Feature] <Allow reading of DICOM images> #68
              
              
                jph6366 e331dfc
              
                Merge branch 'dicom2niix' of https://github.com/jph6366/TF2.4_IVIM-MR…
              
              
                jph6366 1247c2c
              
                Update README.md
              
              
                jph6366 a5f63e6
              
                [Feature] <Allow reading of DICOM images> #68
              
              
                jph6366 0e496b6
              
                [Feature] <Allow reading of DICOM images> #68
              
              
                jph6366 ae56831
              
                Update README.md
              
              
                jph6366 317d72d
              
                [Feature] <Allow reading of DICOM images> #68
              
              
                jph6366 783e2f3
              
                Merge branch 'dicom2niix' of https://github.com/jph6366/TF2.4_IVIM-MR…
              
              
                jph6366 5347a31
              
                [Feature] <Allow reading of DICOM images> #68
              
              
                jph6366 22df73a
              
                [Feature] <Allow reading of DICOM images> #68
              
              
                jph6366 d18c2e6
              
                Update README.md
              
              
                jph6366 3dbb64c
              
                [Feature] <Allow reading of DICOM images> #68
              
              
                jph6366 606b667
              
                Merge branch 'dicom2niix' of https://github.com/jph6366/TF2.4_IVIM-MR…
              
              
                jph6366 9a17fb1
              
                Update README.md
              
              
                jph6366 614c8f8
              
                [Feature] <Allow reading of DICOM images> #68
              
              
                jph6366 dda0e88
              
                Merge branch 'dicom2niix' of https://github.com/jph6366/TF2.4_IVIM-MR…
              
              
                jph6366 ac752cb
              
                Update pyproject.toml
              
              
                jph6366 92abf87
              
                Update generate_signal_docker_test.py
              
              
                jph6366 201f495
              
                [Feature] <Allow reading of DICOM images> #68
              
              
                jph6366 d32460b
              
                Merge branch 'dicom2niix' of https://github.com/jph6366/TF2.4_IVIM-MR…
              
              
                jph6366 9cd090f
              
                Update pyproject.toml
              
              
                jph6366 30a0603
              
                Update README.md
              
              
                jph6366 64dc1bc
              
                updated job to be fixed or otherwise log error to help fix
              
              
                jph6366 682d655
              
                Merge branch 'dicom2niix' of https://github.com/jph6366/TF2.4_IVIM-MR…
              
              
                jph6366 814cdc9
              
                #68
              
              
                jph6366 015f7dc
              
                tested locally successfully
              
              
                jph6366 f3e97ed
              
                isolate (testing utility) dependency
              
              
                jph6366 386ce9d
              
                isolate the cli utility lib as well
              
              
                jph6366 bcda16a
              
                remove interactive mode and inquirer
              
              
                jph6366 b085753
              
                Merge branch 'OSIPI:main' into dicom2niix
              
              
                jph6366 File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
          Some comments aren't visible on the classic Files Changed page.
        
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
                              
      
                  jph6366 marked this conversation as resolved.
               
          
            Show resolved
            Hide resolved
         | 
            
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| FROM debian:stable-slim AS build | ||
| 
     | 
||
| ARG DCM2NIIX_VERSION=v1.0.20241211 | ||
| 
     | 
||
| RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
| build-essential \ | ||
| cmake \ | ||
| git \ | ||
| libssl-dev \ | ||
| wget \ | ||
| pigz \ | ||
| ca-certificates \ | ||
| && update-ca-certificates \ | ||
| && wget https://github.com/rordenlab/dcm2niix/archive/refs/tags/${DCM2NIIX_VERSION}.tar.gz -O /tmp/dcm2niix.tar.gz \ | ||
| && mkdir -p /tmp/dcm2niix && tar -xzf /tmp/dcm2niix.tar.gz -C /tmp/dcm2niix --strip-components=1 \ | ||
| && mkdir /tmp/dcm2niix/build && cd /tmp/dcm2niix/build \ | ||
| && cmake -DBATCH_VERSION=ON -DZLIB_IMPLEMENTATION=Cloudflare -DUSE_JPEGLS=ON -DUSE_OPENJPEG=ON .. \ | ||
| && make && make install \ | ||
| && rm -rf /tmp/dcm2niix* \ | ||
| && apt-get remove -y wget git cmake \ | ||
| && apt-get autoremove -y \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
| 
     | 
||
| FROM python:3.11-slim | ||
| 
     | 
||
| WORKDIR /usr/src/app | ||
| 
     | 
||
| RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
| pigz \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
| 
     | 
||
| COPY --from=build /usr/local/bin/dcm2niix /usr/local/bin/dcm2niix | ||
| 
     | 
||
| COPY ../.. . | ||
| 
     | 
||
| RUN pip install --no-cache-dir . | ||
| 
     | 
||
| ENTRYPOINT ["python3", "-m", "WrapImage.dicom2niix_wrapper"] | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              Empty file.
          
    
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test fails. I think because of the whitespace here.