Skip to content

Conversation

@NeilHanlon
Copy link

This change introduces support for the vmware_desktop provider in Vagrant by generating a VMDK using the Vagrant subformat and embedding it into the resulting Vagrant box.

It also adds support for aarch64 VMware disks (and therefore, boxes) by enabling a sata option for the machine.vmdisk.controller attribute. This option is passed through to the VMware template while preserving the default IDE-based configuration for existing use cases.

Additionally, a pcibridge0 section has been added to the generated VMX configuration. This was required during testing to ensure the resulting image functioned properly.

Lastly, the vagrant_post_init method signature was updated to allow passing extra configuration options (custom_args) into the VMDK creation process, enabling more flexible build customization. Incidently, a type alias for the VagrantConfigDict (Dict['str', xml_parse.vagrantconfig]) was added to clean up long lines.

@NeilHanlon
Copy link
Author

n.b., I know I need tests and to fix existing ones :D

@schaefi
Copy link
Collaborator

schaefi commented Jun 2, 2025

@NeilHanlon Hi, this looks great. Thanks much for the effort 👍

n.b., I know I need tests and to fix existing ones :D

yay :) once this is all green I'm very happy to merge it.

I wrote some documentation about the vagrant use case in the past. You can find this here

  • ./working_with_images/disk_setup_for_vagrant.rst

I believe it would be good to add some information about the new provider and how to use it there too.

Thoughts ?

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed as part of the community meeting.

@github-actions github-actions bot added the stale label Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants