WIP: Add VMware Vagrant Provider Support #2827
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces support for the
vmware_desktopprovider in Vagrant by generating a VMDK using the Vagrant subformat and embedding it into the resulting Vagrant box.It also adds support for
aarch64VMware disks (and therefore, boxes) by enabling a sata option for the machine.vmdisk.controller attribute. This option is passed through to the VMware template while preserving the default IDE-based configuration for existing use cases.Additionally, a pcibridge0 section has been added to the generated VMX configuration. This was required during testing to ensure the resulting image functioned properly.
Lastly, the
vagrant_post_initmethod signature was updated to allow passing extra configuration options (custom_args) into the VMDK creation process, enabling more flexible build customization. Incidently, a type alias for theVagrantConfigDict(Dict['str', xml_parse.vagrantconfig]) was added to clean up long lines.