Skip to content

Remove changesets_in_osmcha from user stats endpoint #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove changesets_in_osmcha from user stats endpoint #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions osmchadjango/changeset/tests/test_stats_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,14 +183,12 @@ def test_user_one_stats(self):
self.client.login(username=self.user.username, password='password')
response = self.client.get(reverse('changeset:user-stats', args=['4321']))
self.assertEqual(response.status_code, 200)
self.assertEqual(response.data.get('changesets_in_osmcha'), 3)
self.assertEqual(response.data.get('checked_changesets'), 2)
self.assertEqual(response.data.get('harmful_changesets'), 1)

def test_user_without_changesets(self):
self.client.login(username=self.user.username, password='password')
response = self.client.get(reverse('changeset:user-stats', args=['1611']))
self.assertEqual(response.status_code, 200)
self.assertEqual(response.data.get('changesets_in_osmcha'), 0)
self.assertEqual(response.data.get('checked_changesets'), 0)
self.assertEqual(response.data.get('harmful_changesets'), 0)
6 changes: 2 additions & 4 deletions osmchadjango/changeset/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,17 +546,15 @@ def user_stats(request, uid):
"""
query = """
SELECT
count(*),
count(*) filter (where checked),
count(*) filter (where harmful)
FROM changeset_changeset
WHERE uid = %s
WHERE uid = %s AND checked = TRUE
"""
with connection.cursor() as cursor:
cursor.execute(query, [str(uid)])
total, checked, harmful = cursor.fetchone()
checked, harmful = cursor.fetchone()
instance = {
"changesets_in_osmcha": total,
"checked_changesets": checked,
"harmful_changesets": harmful
}
Expand Down