Update Password Storage Cheat Sheet: Clarify scrypt parameters and wording improvements #1750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rding improvements
Prasad-JB
requested review from
kwwall,
mackowski,
jmanico and
szh
as code owners
|
Hello! Just a gentle reminder about this PR — it clarifies scrypt parameters to reduce confusion between CPU and memory cost. Please let me know if you’d like any changes or additional explanations. Thanks for your time! |
|
This may take time to approve, all password cheatsheet changes must be approved by @Sc00bz first :) Please give him time! :) |
jmanico
reviewed
Aug 13, 2025
|
|
||
| - N=2^17 (128 MiB), r=8 (1024 bytes), p=1 | ||
| - N=2^16 (64 MiB), r=8 (1024 bytes), p=2 | ||
| - N=2^15 (32 MiB), r=8 (1024 bytes), p=3 | ||
| - N=2^14 (16 MiB), r=8 (1024 bytes), p=5 | ||
| - N=2^13 (8 MiB), r=8 (1024 bytes), p=10 | ||
|
|
||
| These configuration settings provide an equal level of defense. The only difference is a trade off between CPU and RAM usage. | ||
| These configuration settings provide a minimal level of defense. The only difference is a trade off between CPU and RAM usage. |
There was a problem hiding this comment.
I would say "a minimal and an equal" since both are true
There was a problem hiding this comment.
Thanks for the suggestion! I can update the phrasing to “a minimal and an equal level of defense” if that works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Password Storage Cheat Sheet by updating the wording around the scrypt parameters to reduce confusion between CPU cost and memory cost. Specifically, it:
Clarifies the correct description of scrypt’s parameters (N, r, p) to better reflect their roles.
Suggests improved phrasing to accurately represent the trade-offs between CPU and RAM usage.
Fixes minor wording issues for better readability and accuracy in lines 118 and 126 of Password_Storage_Cheat_Sheet.md.
These changes aim to enhance the clarity and precision of the cheat sheet, helping readers better understand password hashing configurations.