Upgraded Tentacle's "NuGet.Packaging" dependency to the latest re-fork #1163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
With the release of the re-fork of the Octopus Nuget.Clients we want to update all our usages to use the new and latest version.
Tentacle depends on it in two places:
We can remove the dependency on
Nuget.Versioning.SemanticVersionby replacing it with the new[Octopus.Versioning.SemanticVersion](https://github.com/OctopusDeploy/Versioning/blob/main/source/Octopus.Versioning/Semver/SemanticVersion.cs)that was modeled off the original fork.We can update the
PackageExtractor.ExtractPackageto instead call the new 6.14.x async onlyPackageExtractor.ExtractPackageAsyncResults
This PR has removed the transitive dependency on
NuGet.Versioningand has updated the package extractor to use the new async variant.There are further improvements to consider:
NuGetVersionin favor ofSemanticVersionThere are still many places that use the string version of
NuGetVersionBefore
After
How to review this PR
Quality ✔️
Pre-requisites