Irfan - Nodejs To C# Conversions #1713
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces C# implementations of two Microsoft Teams samples and updates image references in the TypeScript sample. The work involves creating complete C#/.NET versions of existing Node.js samples, including full application structures, configuration files, and Microsoft 365 Agents Toolkit integration.
- Adds complete C# implementations for Tab Channel Group QuickStart and Tab App Navigation samples
- Updates image references in TypeScript sample to use lowercase naming convention
- Provides comprehensive documentation and setup instructions for both new C# samples
Reviewed Changes
Copilot reviewed 60 out of 89 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| samples/tab-channel-group-quickstart/ts/* | Updates image references and documentation with lowercase filenames |
| samples/tab-channel-group-quickstart/csharp/* | Complete new C# implementation with web app, views, controllers, and M365 toolkit integration |
| samples/tab-app-navigation/csharp/* | Complete new C# implementation with navigation functionality and M365 toolkit support |
| "type": "image", | ||
| "order": 100, | ||
| "url": "https://raw.githubusercontent.com/OfficeDev/Microsoft-Teams-Samples/main/samples/tab-channel-group-quickstart/csharp/Microsoft.Teams.Samples.TabChannelGroupQuickstart.Web/Images/tab_channel_group_module.gif", | ||
| "alt": "Solution UX showing starter solution: channel/group tab in typescript" |
There was a problem hiding this comment.
The alt text incorrectly states 'typescript' but this is for a C# sample. It should say 'C#' or 'csharp' instead.
| "alt": "Solution UX showing starter solution: channel/group tab in typescript" | |
| "alt": "Solution UX showing starter solution: channel/group tab in C#" |
| "shortDescription": "This sample demonstrates tab navigation functionality, allowing users to switch between tabs in a Teams application.", | ||
| "url": "https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/tab-app-navigation/csharp", | ||
| "longDescription": [ | ||
| "This sample illustrates the tab navigation feature in a Microsoft Teams application, enabling smooth transitions between different tabs. Designed for use with Node.js, it highlights how users can effectively navigate within the app for an enhanced experience." |
There was a problem hiding this comment.
The description mentions 'Node.js' but this is a C# sample. It should reference '.NET' or 'C#' instead.
| "This sample illustrates the tab navigation feature in a Microsoft Teams application, enabling smooth transitions between different tabs. Designed for use with Node.js, it highlights how users can effectively navigate within the app for an enhanced experience." | |
| "This sample illustrates the tab navigation feature in a Microsoft Teams application, enabling smooth transitions between different tabs. Designed for use with .NET, it highlights how users can effectively navigate within the app for an enhanced experience." |
| @@ -0,0 +1,6 @@ | |||
| @* Copyright(c) Microsoft Corporation. All rights reserved. | |||
| Licensed under the MIT License *@ | |||
There was a problem hiding this comment.
The comment is incomplete - it should end with 'License.' instead of 'License *@'
| Licensed under the MIT License *@ | |
| Licensed under the MIT License. *@ |
| @@ -0,0 +1,6 @@ | |||
| @* Copyright (c) Microsoft Corporation. All rights reserved. | |||
| Licensed under the MIT Lic *@ | |||
There was a problem hiding this comment.
The comment is incomplete and misspelled - it should be 'Licensed under the MIT License.' instead of 'Licensed under the MIT Lic *@'
| Licensed under the MIT Lic *@ | |
| Licensed under the MIT License. |
| @@ -0,0 +1,26 @@ | |||
| @* Copyright (c) Microsoft Corporation. All rights reserved. | |||
| Licensed under the MIT Lic *@ | |||
There was a problem hiding this comment.
The comment is incomplete and misspelled - it should be 'Licensed under the MIT License.' instead of 'Licensed under the MIT Lic *@'
| Licensed under the MIT Lic *@ | |
| Licensed under the MIT License. *@ |
| @@ -0,0 +1,58 @@ | |||
| @* Copyright (c) Microsoft Corporation. All rights reserved. | |||
| Licensed under the MIT Lic *@ | |||
There was a problem hiding this comment.
The comment is incomplete and misspelled - it should be 'Licensed under the MIT License.' instead of 'Licensed under the MIT Lic *@'
| Licensed under the MIT Lic *@ | |
| Licensed under the MIT License. *@ |
| @@ -0,0 +1,64 @@ | |||
| @* Copyright (c) Microsoft Corporation. All rights reserved. | |||
| Licensed under the MIT Lic *@ | |||
There was a problem hiding this comment.
The comment is incomplete and misspelled - it should be 'Licensed under the MIT License.' instead of 'Licensed under the MIT Lic *@'
| Licensed under the MIT Lic *@ | |
| Licensed under the MIT License. *@ |
| @@ -0,0 +1,78 @@ | |||
| @* Copyright (c) Microsoft Corporation. All rights reserved. | |||
| Licensed under the MIT Lic *@ | |||
There was a problem hiding this comment.
The comment is incomplete and misspelled - it should be 'Licensed under the MIT License.' instead of 'Licensed under the MIT Lic *@'
| Licensed under the MIT Lic *@ | |
| Licensed under the MIT License. *@ |
| @@ -0,0 +1,79 @@ | |||
| @* Copyright (c) Microsoft Corporation. All rights reserved. | |||
| Licensed under the MIT Lic *@ | |||
There was a problem hiding this comment.
The comment is incomplete and misspelled - it should be 'Licensed under the MIT License.' instead of 'Licensed under the MIT Lic *@'
| Licensed under the MIT Lic *@ | |
| Licensed under the MIT License. *@ |
| @@ -0,0 +1,42 @@ | |||
| @* Copyright (c) Microsoft Corporation. All rights reserved. | |||
| Licensed under the MIT Lic *@ | |||
There was a problem hiding this comment.
The comment is incomplete and misspelled - it should be 'Licensed under the MIT License.' instead of 'Licensed under the MIT Lic *@'
| Licensed under the MIT Lic *@ | |
| Licensed under the MIT License. *@ |
| > If you do not have permission to upload custom apps (uploading), Microsoft 365 Agents Toolkit will recommend creating and using a Microsoft 365 Developer Program account - a free program to get your own dev environment sandbox that includes Teams. | ||
|
|
||
| ### Setup | ||
| ### Setup |
| - Get the external app id from teams admin portal.(https://admin.teams.microsoft.com/policies/manage-apps) | ||
| - Navigate to the appropriate C# file in your project where the external app id is referenced and replace placeholder `<<External-App-Id>>` with your actual external app id which you can get from teams admin portal. | ||
|
|
||
|  |
| "shortDescription": "This sample demonstrates tab navigation functionality, allowing users to switch between tabs in a Teams application.", | ||
| "url": "https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/tab-app-navigation/csharp", | ||
| "longDescription": [ | ||
| "This sample illustrates the tab navigation feature in a Microsoft Teams application, enabling smooth transitions between different tabs. Designed for use with Node.js, it highlights how users can effectively navigate within the app for an enhanced experience." |
There was a problem hiding this comment.
replace "Designed for use with Node.js," to "Designed for use with .NET,"
There was a problem hiding this comment.
Need to hide domain inside the email
There was a problem hiding this comment.
remove domain inside the email
There was a problem hiding this comment.
remove domain in email
There was a problem hiding this comment.
remove domain in email
2.Tab App Navigation