fix: add help link when user meet error for uploading da package #14485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuihuiWu-Microsoft
requested review from
tecton,
llhmm01 and
wh-alice
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/6.2 #14485 +/- ##
===============================================
- Coverage 90.09% 90.09% -0.01%
===============================================
Files 650 650
Lines 39003 39008 +5
Branches 7744 7711 -33
===============================================
+ Hits 35141 35144 +3
- Misses 1746 1747 +1
- Partials 2116 2117 +1
🚀 New features to boost your workflow:
|
tecton
reviewed
Sep 10, 2025
| export const outlookBaseUrl = "https://outlook.office.com"; | ||
| export const officeBaseUrl = "https://www.office.com"; | ||
| export const advancedDASettingUrl = "https://aka.ms/atk-actions/teamsapp-extendToM365"; | ||
| export const M365HelpLink = "https://aka.ms/teamsfx-actions/teamsapp-extendToM365"; |
There was a problem hiding this comment.
Shall we avoid using teamsfx in URL?
There was a problem hiding this comment.
This is the existing aka link. I don't think we can remove it for now since it'll break former version.
summzhan
approved these changes
Sep 11, 2025
tecton
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide help link when user failed to upload package. Reuse the existing aka link and I'll update the wiki content later
ADO: fix #2.1 in https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/34648353/?view=edit
Screenshot: