Skip to content

Add npm to CI build #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2023
Merged

Add npm to CI build #1049

merged 3 commits into from
Oct 3, 2023

Conversation

@manandre
Copy link
Contributor

@manandre manandre commented Oct 2, 2023

Should avoid introducing breaking changes in the vscode-testextension project and int its npm dependencies in particular.

@github-actions github-actions bot added this to the v0.19.10 milestone Oct 2, 2023
@JoeRobich
Copy link
Member

So, for C# extension integration tests we needed to setup a virtual display for our linux leg and pass the id in the DISPLAY environment variable. See https://github.com/dotnet/vscode-csharp/blob/ed352248c09fa57cfb2c2c0b04874fd122a26538/.github/workflows/ci.yml#L18

JoeRobich
JoeRobich approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manandre!

@JoeRobich JoeRobich merged commit 00adbe3 into OmniSharp:master Oct 3, 2023
@github-actions github-actions bot added the mysterious We forgot to label this label Oct 3, 2023
@manandre manandre deleted the npm-ci branch October 3, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees

No one assigned

Labels

mysterious We forgot to label this

Projects

None yet

Milestone

v0.19.10

Development

Successfully merging this pull request may close these issues.

2 participants

@manandre @JoeRobich