fix: process detection if its a single path #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`i = 1` rightly skips the first index as it is commonly empty (on linux) or a drive letter (windows) but this wrongly captures single path processes on linux. This explicitly filters out those undesired first indexes instead of skipping ALL of them.
Milkshiift
added a commit
to Milkshiift/arrpc
that referenced
this pull request
Dec 21, 2024
CanadaHonk
requested changes
Jan 15, 2025
Vendicated
reviewed
Oct 4, 2025
| const path = _path.toLowerCase().replaceAll('\\', '/'); | ||
| for (const [ pid, path, args ] of processes) { | ||
| const splitPath = path.toLowerCase().replaceAll('\\', '/').split('/'); | ||
| if ((splitPath[0] == 2 && splitPath[0].endsWith(':') || splitPath[0] == "")) { |
There was a problem hiding this comment.
you probably meant to use length here
Suggested change
| if ((splitPath[0] == 2 && splitPath[0].endsWith(':') || splitPath[0] == "")) { | |
| if ((splitPath[0].length == 2 && splitPath[0].endsWith(':') || splitPath[0] == "")) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i = 1rightly skips the first index as it is commonly empty (on linux) or a drive letter (windows) but this wrongly captures single path processes on linux. This explicitly filters out those undesired first indexes instead of skipping ALL of them.