Improve linux game detection #92
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some games are listed in the discord game database with their parent directories but their launched processes on linux don't always have this included in cmdline. This fixes that by checking processes with their working directories as well. For example, this will now detect DOOM Eternal running through proton.
|
+1 hope this gets merged soon |
|
This adds an incredible amount of lag to scanning. is not viable. |
Good catch. It should somehow filter processes to only check "Windows working directory" for processes that belong to Wine. |
|
simply work, thats great! i can't wait this merge. |
Milkshiift
added a commit
to Milkshiift/arrpc
that referenced
this pull request
Dec 21, 2024
|
Would love to see this implemented, works beautifully! |
XenHat
added a commit
to XenHat/arrpc
that referenced
this pull request
Mar 12, 2025
Tested against https://github.com/OpenAsar/arrpc/blob/2234e9c9111f4c42ebcc3aa6a2215bfd979eef77/src/process/detectable.json and confirmed to detect the following on Linux: - Zenless Zone Zero - Honkai: Star Rail - Genshin Impact - Horizon Zero Dawn - Journey Built upon OpenAsar#92
This was referenced Mar 12, 2025
|
any updates? |
If you need the fix sooner, run your own copy of the repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some games are listed in the discord game database with their parent directories but their launched processes on linux don't always have this included in their cmdline. This fixes that by checking processes with their working directories as well.
For example, this will now detect DOOM Eternal running through proton.