refactor: update media upload button and tooltip in media panel, so i… #557
Conversation
…t looks less silly
|
@marcelytumy is attempting to deploy a commit to the OpenCut OSS Team on Vercel. A member of the Team first needs to authorize it. |
👷 Deploy request for appcut pending review.Visit the deploys page to approve it
|
WalkthroughReplaced the upload control’s icon and button style, added a tooltip, and adjusted spinner sizing within the media panel view. The underlying file selection, processing, and drag-and-drop logic remain unchanged. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/web/src/components/editor/media-panel/views/media.tsx (1)
297-315: Tooltips on disabled buttons may not show; consider wrapper patternMany tooltip libs (e.g., Radix-based) don’t show tooltips on disabled elements. If you want the tooltip to remain visible while isProcessing is true, wrap the disabled button with a non-disabled element and use it as the trigger.
Here’s the pattern using a span wrapper (can be combined with the previous diff):
- <Tooltip> - <TooltipTrigger asChild> - <Button + <Tooltip> + <TooltipTrigger asChild> + <span className="inline-flex" aria-disabled={isProcessing}> + <Button variant="text" size="icon" type="button" aria-label={isProcessing ? "Uploading…" : "Upload media"} onClick={handleFileSelect} disabled={isProcessing} - > + > {isProcessing ? ( ... ) : ( ... )} - </Button> + </Button> + </span> </TooltipTrigger> <TooltipContent> <p>Upload media</p> </TooltipContent> </Tooltip>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/web/src/components/editor/media-panel/views/media.tsx(2 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{jsx,tsx}
📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)
**/*.{jsx,tsx}: Don't useaccessKeyattribute on any HTML element.
Don't setaria-hidden="true"on focusable elements.
Don't add ARIA roles, states, and properties to elements that don't support them.
Don't use distracting elements like<marquee>or<blink>.
Only use thescopeprop on<th>elements.
Don't assign non-interactive ARIA roles to interactive HTML elements.
Make sure label elements have text content and are associated with an input.
Don't assign interactive ARIA roles to non-interactive HTML elements.
Don't assigntabIndexto non-interactive HTML elements.
Don't use positive integers fortabIndexproperty.
Don't include "image", "picture", or "photo" in img alt prop.
Don't use explicit role property that's the same as the implicit/default role.
Make static elements with click handlers use a valid role attribute.
Always include atitleelement for SVG elements.
Give all elements requiring alt text meaningful information for screen readers.
Make sure anchors have content that's accessible to screen readers.
AssigntabIndexto non-interactive HTML elements witharia-activedescendant.
Include all required ARIA attributes for elements with ARIA roles.
Make sure ARIA properties are valid for the element's supported roles.
Always include atypeattribute for button elements.
Make elements with interactive roles and handlers focusable.
Give heading elements content that's accessible to screen readers (not hidden witharia-hidden).
Always include alangattribute on the html element.
Always include atitleattribute for iframe elements.
AccompanyonClickwith at least one of:onKeyUp,onKeyDown, oronKeyPress.
AccompanyonMouseOver/onMouseOutwithonFocus/onBlur.
Include caption tracks for audio and video elements.
Use semantic elements instead of role attributes in JSX.
Make sure all anchors are valid and navigable.
Ensure all ARIA properties (aria-*) are valid.
Use valid, non-abstract ARIA roles for elements with...
Files:
apps/web/src/components/editor/media-panel/views/media.tsx
**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Don't use TypeScript enums.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use TypeScript namespaces.
Don't use non-null assertions with the!postfix operator.
Don't use parameter properties in class constructors.
Don't use user-defined types.
Useas constinstead of literal types and type annotations.
Use eitherT[]orArray<T>consistently.
Initialize each enum member value explicitly.
Useexport typefor types.
Useimport typefor types.
Make sure all enum members are literal values.
Don't use TypeScript const enum.
Don't declare empty interfaces.
Don't let variables evolve into any type through reassignments.
Don't use the any type.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use implicit any type on variable declarations.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use the TypeScript directive @ts-ignore.
Use consistent accessibility modifiers on class properties and methods.
Use function types instead of object types with call signatures.
Don't use void type outside of generic or return types.
**/*.{ts,tsx}: Don't use primitive type aliases or misleading types
Don't use the TypeScript directive @ts-ignore
Don't use TypeScript enums
Use either T[] or Array consistently
Don't use the any type
Files:
apps/web/src/components/editor/media-panel/views/media.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)
**/*.{js,jsx,ts,tsx}: Don't use the return value of React.render.
Don't use consecutive spaces in regular expression literals.
Don't use theargumentsobject.
Don't use primitive type aliases or misleading types.
Don't use the comma operator.
Don't write functions that exceed a given Cognitive Complexity score.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use uselessthisaliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names that aren't base 10 or use underscore separators.
Remove redundant terms from logical expressions.
Use while loops instead of...
Files:
apps/web/src/components/editor/media-panel/views/media.tsx
**/*.{tsx,jsx}
📄 CodeRabbit Inference Engine (.cursor/rules/ultracite.mdc)
**/*.{tsx,jsx}: Always include a title element for icons unless there's text beside the icon
Always include a type attribute for button elements
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress
Accompany onMouseOver/onMouseOut with onFocus/onBlur
Don't import React itself
Don't define React components inside other components
Don't use both children and dangerouslySetInnerHTML on the same element
Don't insert comments as text nodes
Use <>...</> instead of ...
Files:
apps/web/src/components/editor/media-panel/views/media.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit Inference Engine (.cursor/rules/ultracite.mdc)
**/*.{ts,tsx,js,jsx}: Don't use the comma operator
Use for...of statements instead of Array.forEach
Don't initialize variables to undefined
Use .flatMap() instead of map().flat() when possible
Don't assign a value to itself
Avoid unused imports and variables
Don't use await inside loops
Don't hardcode sensitive data like API keys and tokens
Don't use the delete operator
Don't use global eval()
Use String.slice() instead of String.substr() and String.substring()
Don't use else blocks when the if block breaks early
Put default function parameters and optional function parameters last
Use new when throwing an error
Use String.trimStart() and String.trimEnd() over String.trimLeft() and String.trimRight()
Files:
apps/web/src/components/editor/media-panel/views/media.tsx
🧬 Code Graph Analysis (1)
apps/web/src/components/editor/media-panel/views/media.tsx (2)
apps/web/src/components/ui/tooltip.tsx (3)
Tooltip(72-72)TooltipTrigger(72-72)TooltipContent(72-72)apps/web/src/components/ui/button.tsx (1)
Button(61-61)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Vade Review
🔇 Additional comments (1)
apps/web/src/components/editor/media-panel/views/media.tsx (1)
8-8: Icon swap to lucide-react Upload looks goodReplacing CloudUpload with Upload aligns with the rest of the lucide icon set usage and supports the new compact control.
| <Button | ||
| variant="text" | ||
| size="icon" | ||
| onClick={handleFileSelect} | ||
| disabled={isProcessing} | ||
| > | ||
| {isProcessing ? ( | ||
| <Loader2 className="!size-4 animate-spin" /> | ||
| ) : ( | ||
| <Upload className="!size-4" /> | ||
| )} | ||
| </Button> | ||
| </TooltipTrigger> |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add button type and accessible name; include titles on icons
- Buttons must declare type to avoid unintended form submissions.
- Icon-only buttons need an accessible name; tooltips do not provide an accessible name for assistive tech.
- Our guidelines require a title element for SVG icons in TSX/JSX.
Apply the following changes:
- Add type="button" and a descriptive aria-label to the Button.
- Add title to both icons (and optionally aria-hidden to avoid double announcements).
- Optionally normalize icon stroke width to match adjacent controls and reduce visual weight.
- <Button
- variant="text"
- size="icon"
- onClick={handleFileSelect}
- disabled={isProcessing}
- >
- {isProcessing ? (
- <Loader2 className="!size-4 animate-spin" />
- ) : (
- <Upload className="!size-4" />
- )}
+ <Button
+ variant="text"
+ size="icon"
+ type="button"
+ aria-label={isProcessing ? "Uploading…" : "Upload media"}
+ onClick={handleFileSelect}
+ disabled={isProcessing}
+ >
+ {isProcessing ? (
+ <Loader2
+ className="!size-4 animate-spin"
+ strokeWidth={1.5}
+ aria-hidden="true"
+ title="Uploading…"
+ />
+ ) : (
+ <Upload
+ className="!size-4"
+ strokeWidth={1.5}
+ aria-hidden="true"
+ title="Upload media"
+ />
+ )}
</Button>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <Button | |
| variant="text" | |
| size="icon" | |
| onClick={handleFileSelect} | |
| disabled={isProcessing} | |
| > | |
| {isProcessing ? ( | |
| <Loader2 className="!size-4 animate-spin" /> | |
| ) : ( | |
| <Upload className="!size-4" /> | |
| )} | |
| </Button> | |
| </TooltipTrigger> | |
| <Button | |
| variant="text" | |
| size="icon" | |
| type="button" | |
| aria-label={isProcessing ? "Uploading…" : "Upload media"} | |
| onClick={handleFileSelect} | |
| disabled={isProcessing} | |
| > | |
| {isProcessing ? ( | |
| <Loader2 | |
| className="!size-4 animate-spin" | |
| strokeWidth={1.5} | |
| aria-hidden="true" | |
| title="Uploading…" | |
| /> | |
| ) : ( | |
| <Upload | |
| className="!size-4" | |
| strokeWidth={1.5} | |
| aria-hidden="true" | |
| title="Upload media" | |
| /> | |
| )} | |
| </Button> |
🤖 Prompt for AI Agents
In apps/web/src/components/editor/media-panel/views/media.tsx around lines 299
to 311, the icon-only Button is missing a button type and accessible name and
the SVG icons lack title attributes; update the Button to include type="button"
and a descriptive aria-label (e.g., aria-label="Upload media" or similar), add a
<title> to each SVG icon (and set aria-hidden="true" on the SVGs if you want to
avoid duplicate announcements), and optionally normalize the icons' strokeWidth
to match adjacent controls for consistent visual weight.
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| <TooltipContent> | ||
| <p>Upload media</p> | ||
| </TooltipContent> | ||
| </Tooltip> |
There was a problem hiding this comment.
Missing closing </Tooltip> tag after the view mode button's TooltipContent, causing invalid JSX structure when the next <Tooltip> opens.
View Details
📝 Patch Details
diff --git a/apps/web/src/components/editor/media-panel/views/media.tsx b/apps/web/src/components/editor/media-panel/views/media.tsx
index ec85507..abca8b1 100644
--- a/apps/web/src/components/editor/media-panel/views/media.tsx
+++ b/apps/web/src/components/editor/media-panel/views/media.tsx
@@ -343,7 +343,8 @@ export function MediaView() {
: "Switch to grid view"}
</p>
</TooltipContent>
- <Tooltip>
+ </Tooltip>
+ <Tooltip>
<DropdownMenu>
<TooltipTrigger asChild>
<DropdownMenuTrigger asChild>
Analysis
The tooltip structure for the view mode button (starting at line 316) is not properly closed before a new tooltip opens at line 346. The current structure has:
<Tooltip>opens at line 316 (view mode button)</TooltipContent>closes at line 345<Tooltip>opens again at line 346 (dropdown button)
However, there's no </Tooltip> tag to close the view mode button's tooltip before the dropdown tooltip starts. This creates invalid JSX structure where tooltips are improperly nested, which will cause React rendering errors or compilation failures.
The structure should be:
</TooltipContent>
</Tooltip> // ← This is missing
<Tooltip>Recommendation
Add the missing </Tooltip> closing tag after line 345 (</TooltipContent>) and before line 346 (<Tooltip>). The corrected structure should be:
</TooltipContent>
</Tooltip>
<Tooltip>1 participant
…t looks less silly
Description
The previous upload button was visually heavy and inconsistent with the rest of the media panel controls, making the toolbar look unbalanced and silly.
Type of change
Screenshots
before
after
Checklist:
Summary by CodeRabbit
New Features
Style
Refactor