Skip to content

Conversation

Zonespace27
Copy link
Contributor

@Zonespace27 Zonespace27 commented Jun 29, 2025

Adds unit testing to alists for:

  • Valid key types
  • Valid value types
  • Setting/Getting
  • Various procs that can use alists
  • All the /list procs that are usable on alists
  • Compounded alists

closes #2297

@boring-cyborg boring-cyborg bot added the Runtime Involves the OpenDream server/runtime label Jun 29, 2025
@github-actions github-actions bot added size/L and removed size/M labels Jun 29, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Zonespace27 Zonespace27 marked this pull request as ready for review September 24, 2025 18:54
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InspectCode found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link
Collaborator

@amylizzle amylizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comprehensive tests, good fixes - just a couple comments to address

@Zonespace27 Zonespace27 requested a review from amylizzle October 7, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Runtime Involves the OpenDream server/runtime size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/alist needs unit tests
3 participants