feat: Add automatic loading of user skills from home directory #950

whywaita · 2025-10-29T08:31:20Z

Summary

This PR implements automatic loading of user skills from the user's home directory, allowing users to define custom skills that are automatically available across all agents without explicit configuration.

Changes

Core Implementation

✅ Added load_user_skills() function that loads skills from:
- ~/.openhands/skills/ (primary location)
- ~/.openhands/microagents/ (legacy support for backward compatibility)
✅ Added load_user_skills field to AgentContext (default: True)
✅ Implemented automatic merging of user skills with explicitly provided skills
✅ Explicit skills take precedence over user skills when names conflict
✅ Skills from ~/.openhands/skills/ take precedence over ~/.openhands/microagents/

API Updates

✅ Exported load_user_skills function from openhands.sdk.context module
✅ Added model validator to AgentContext for automatic user skills loading

Testing

✅ Added comprehensive test suite (tests/sdk/context/skill/test_load_user_skills.py)
- Tests for loading from both directories
- Tests for priority and precedence rules
- Tests for duplicate handling
- Tests for error handling
- Tests for AgentContext integration
✅ Updated existing tests to disable user skills loading where appropriate

Behavior

When enabled (default)

User skills are automatically loaded from home directory
Merged with any explicitly provided skills
Duplicate names are handled gracefully (explicit skills take precedence)

When disabled (`load_user_skills=False`)

Only explicitly provided skills are used
No automatic loading occurs

Testing

All new tests pass
Existing tests updated and passing
Error handling tested (invalid skills, missing directories)
Priority and precedence rules verified

Summary

I've successfully made the pre-commit checks pass on the feat/implement-user-skills branch and pushed the changes to the fork.

What was done:

✅ Checked out the branch: Successfully fetched and checked out whywaita:feat/implement-user-skills

✅ Ran pre-commit checks: Identified formatting issues in tests/sdk/context/test_agent_context.py

✅ Fixed formatting issues: The ruff formatter reformatted 3 lines in the test file to split long AgentContext constructor calls across multiple lines for better readability

✅ Committed changes: Created commit with message "style: Format code with ruff" and proper co-author attribution

✅ Verified all checks pass: All pre-commit hooks now pass successfully:

Format YAML files ✓
Ruff format ✓
Ruff lint ✓
PEP8 style check ✓
Type check with basedpyright ✓

✅ Pushed to fork: Successfully pushed the changes to whywaita/agent-sdk repository

Changes made:

File modified: tests/sdk/context/test_agent_context.py (9 insertions, 3 deletions)
Change type: Code formatting only - split long lines to comply with style guidelines

The PR #950 has been updated with the formatting fix and all pre-commit checks now pass on the branch.

_{View full conversation}

openhands-sdk/openhands/sdk/context/agent_context.py

xingyaoww · 2025-11-04T19:28:08Z

tests/sdk/context/test_agent_context.py

-        context = AgentContext(skills=[python_agent, testing_agent])
+        context = AgentContext(
+            load_user_skills=False, skills=[python_agent, testing_agent]
+        )


@OpenHands you are on a fork branch whywaita:feat/implement-user-skills (pls reset the remote url before you push) - load_user_skills should be optional arg, can you remove the changes we added in test_agent_context.py in this PR?

I'm on it! xingyaoww can track my progress at all-hands.dev

Summary of Changes

I've successfully completed your request to clean up the test files in PR #950. Here's what was done:

Changes Made (2 commits):

Commit 1: 9bdec4c8 - "Remove explicit load_user_skills=False from test_agent_context.py"

✅ Removed all explicit load_user_skills=False parameters from test_agent_context.py

This eliminated ~16 redundant parameter assignments since False is already the default value

Commit 2: f402f638 - "Fix tests: explicitly set load_user_skills=True where needed"

✅ Fixed 3 tests in test_load_user_skills.py that were failing after the default value change

These tests specifically verify the auto-loading functionality, so they need load_user_skills=True

Updated tests:

test_agent_context_loads_user_skills_by_default

test_agent_context_merges_explicit_and_user_skills

test_agent_context_explicit_skill_takes_precedence

Test Results:

✅ All 111 tests in tests/sdk/context/ pass

✅ Pre-commit hooks pass (Ruff format, Ruff lint, pycodestyle, pyright)

PR Status:

Branch: feat/implement-user-skills on fork whywaita/agent-sdk

PR feat: Add automatic loading of user skills from home directory #950 has been updated with both commits

Current HEAD: f402f6387605f8866c53e2bb6f927ceb36326179

The PR is now cleaner with redundant parameters removed while maintaining full test coverage and functionality.

_{View full conversation}

Since load_user_skills defaults to False in AgentContext, there's no need to explicitly set it in tests. This makes the tests cleaner and relies on the default behavior. Co-authored-by: openhands <[email protected]>

Since load_user_skills defaults to False, tests that expect automatic loading of user skills need to explicitly enable it. Updated tests: - test_agent_context_loads_user_skills_by_default - test_agent_context_merges_explicit_and_user_skills - test_agent_context_explicit_skill_takes_precedence Co-authored-by: openhands <[email protected]>

xingyaoww

Thanks!

enyst · 2025-11-04T20:18:03Z

@OpenHands Post an issue on OpenHands/OpenHands, tag it as CLI, for the CLI to

offer a setting for users to enable loading Skills from user home (what this PR does)
enable it by default in CLI.

openhands-ai · 2025-11-04T20:18:12Z

I'm on it! enyst can track my progress at all-hands.dev

openhands-ai · 2025-11-04T20:27:30Z

Summary of work completed

Created a new issue in OpenHands/OpenHands requesting CLI support for loading user Skills from the home directory, with default enabled.
- Title: CLI: Add setting to load user skills from home (enabled by default)
- URL: CLI: Add setting to load user skills from home (enabled by default) OpenHands#11641
- Label: CLI

What’s in the issue

Clear proposal for:
- A config option and CLI flags to enable/disable loading user Skills
- Default behavior: enabled
- Wiring CLI to pass load_user_skills=True to AgentContext
Acceptance criteria aligning with SDK behavior (explicit > user; skills/ > microagents/)
References:
- SDK PR feat: Add automatic loading of user skills from home directory #950
- Related closed issue #11483

Checks

Verified existing CLI label in OpenHands/OpenHands
No changes were made to the current repository or branch (feat/implement-user-skills)

If you want any edits to the issue’s title, scope, or acceptance criteria, I can update it.

_{View full conversation}

Implement a user skills

405d145

blacksmith-sh bot requested a review from xingyaoww October 31, 2025 13:00

xingyaoww reviewed Oct 31, 2025

View reviewed changes

openhands-sdk/openhands/sdk/context/skills/skill.py Outdated Show resolved Hide resolved

openhands-sdk/openhands/sdk/context/agent_context.py Outdated Show resolved Hide resolved

xingyaoww added 2 commits November 5, 2025 03:18

Update openhands-sdk/openhands/sdk/context/skills/skill.py

d4aa634

Update openhands-sdk/openhands/sdk/context/agent_context.py

e004fd5

style: Format code with ruff

df7242f

Co-authored-by: openhands <[email protected]>

Merge branch 'main' into feat/implement-user-skills

eb7cbdc

xingyaoww reviewed Nov 4, 2025

View reviewed changes

openhands-sdk/openhands/sdk/context/agent_context.py Outdated Show resolved Hide resolved

Apply suggestion from @xingyaoww

45f9d42

xingyaoww reviewed Nov 4, 2025

View reviewed changes

openhands-sdk/openhands/sdk/context/agent_context.py Outdated Show resolved Hide resolved

Apply suggestion from @xingyaoww

6e4f141

xingyaoww reviewed Nov 4, 2025

View reviewed changes

xingyaoww mentioned this pull request Nov 4, 2025

GitHub resolver should automatically handle fork branches OpenHands/OpenHands#11638

Open

openhands-agent added 2 commits November 4, 2025 19:31

Remove explicit load_user_skills=False from test_agent_context.py

9bdec4c

Since load_user_skills defaults to False in AgentContext, there's no need to explicitly set it in tests. This makes the tests cleaner and relies on the default behavior. Co-authored-by: openhands <[email protected]>

xingyaoww approved these changes Nov 4, 2025

View reviewed changes

xingyaoww merged commit b8de86c into OpenHands:main Nov 4, 2025
13 checks passed

enyst mentioned this pull request Nov 4, 2025

CLI: Add setting to load user skills from home (enabled by default) OpenHands/OpenHands#11641

Open

feat: Add automatic loading of user skills from home directory #950

feat: Add automatic loading of user skills from home directory #950

Conversation

whywaita commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Core Implementation

API Updates

Testing

Behavior

When enabled (default)

When disabled (load_user_skills=False)

Testing

Related

Uh oh!

blacksmith-sh bot commented Oct 31, 2025

Uh oh!

Uh oh!

Uh oh!

xingyaoww commented Nov 4, 2025

Uh oh!

openhands-ai bot commented Nov 4, 2025

Uh oh!

openhands-ai bot commented Nov 4, 2025

Summary

What was done:

Changes made:

Uh oh!

Uh oh!

Uh oh!

xingyaoww Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

openhands-ai bot Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

openhands-ai bot Nov 4, 2025

Choose a reason for hiding this comment

Summary of Changes

Changes Made (2 commits):

Test Results:

PR Status:

Uh oh!

xingyaoww left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

enyst commented Nov 4, 2025

Uh oh!

openhands-ai bot commented Nov 4, 2025

Uh oh!

openhands-ai bot commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

whywaita commented Oct 29, 2025 •

edited

Loading

When disabled (`load_user_skills=False`)