Skip to content

Conversation

zerog2k
Copy link
Contributor

@zerog2k zerog2k commented Aug 22, 2024

per wdt.ko:

parm=nodeamon:By default, a kernel deamon feed watchdog when idle, set 'nodeamon=1' to disable this. (default=0)
parmtype=nodeamon:int

as documented in OpenIPC/majestic#171, when majestic crashes, without nodeamon=1 param to wdt kmod, camera does not automatically reboot.

Expected behavior is for majestic to feed the watchdog, and if majestic crashes, watchdog timer would expire and reset cpu, forcing host reboot.

per wdt.ko:
```
parm=nodeamon:By default, a kernel deamon feed watchdog when idle, set 'nodeamon=1' to disable this. (default=0)
parmtype=nodeamon:int
```
as documented in OpenIPC/majestic#171, when majestic crashes, without `nodeamon=1` param to wdt kmod, camera does not automatically reboot.

Expected behavior is for majestic to feed the watchdog, and if majestic crashes, watchdog timer would expire and reset cpu, forcing host reboot.
@zerog2k zerog2k changed the title fix watchdog when majestic crashes fix watchdog when majestic crashes on hi3516cv100 Aug 23, 2024
Copy link
Member

@flyrouter flyrouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you
Your suggestion will be considered

@Flole998
Copy link

I've discovered this a few months ago, performed the change and for me it was an improvement as now the camera reboots when there's an issue.

@flyrouter
Copy link
Member

Good day
Thank you for waiting.
I will try to check it on my device during the weekend.

@Flole998
Copy link

@flyrouter Anything new? This has also been reported as #1803

@flyrouter
Copy link
Member

Good day
Thank you for your explanations and suggestions.

However, do you realize the risks that the device will be lost if a crash occurs for some reason during a firmware update and then only UART will help you?

Also, have you tried to reduce the watchdog timeout, for example, to 30 seconds with the command "cli -s .watchdog.timeout 30"?

I would like to explain the problem once again - the current original watchdog driver for all versions of HiSilicon devices is extremely unstable, one might say that it is broken and requires a complete rewrite and inclusion in the openhisilicon repository package.

If watchdog is enabled by default in active mode, there will be many more complaints, since devices will be killed by users during incorrect updates and experiments.

The use of this PR is frozen but not rejected due to the fact that a lot of testing needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants