-
-
Notifications
You must be signed in to change notification settings - Fork 333
fix watchdog when majestic crashes on hi3516cv100 #1534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
per wdt.ko: ``` parm=nodeamon:By default, a kernel deamon feed watchdog when idle, set 'nodeamon=1' to disable this. (default=0) parmtype=nodeamon:int ``` as documented in OpenIPC/majestic#171, when majestic crashes, without `nodeamon=1` param to wdt kmod, camera does not automatically reboot. Expected behavior is for majestic to feed the watchdog, and if majestic crashes, watchdog timer would expire and reset cpu, forcing host reboot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Your suggestion will be considered
I've discovered this a few months ago, performed the change and for me it was an improvement as now the camera reboots when there's an issue. |
Good day |
@flyrouter Anything new? This has also been reported as #1803 |
Good day However, do you realize the risks that the device will be lost if a crash occurs for some reason during a firmware update and then only UART will help you? Also, have you tried to reduce the watchdog timeout, for example, to 30 seconds with the command "cli -s .watchdog.timeout 30"? I would like to explain the problem once again - the current original watchdog driver for all versions of HiSilicon devices is extremely unstable, one might say that it is broken and requires a complete rewrite and inclusion in the openhisilicon repository package. If watchdog is enabled by default in active mode, there will be many more complaints, since devices will be killed by users during incorrect updates and experiments. The use of this PR is frozen but not rejected due to the fact that a lot of testing needs to be done. |
per wdt.ko:
as documented in OpenIPC/majestic#171, when majestic crashes, without
nodeamon=1
param to wdt kmod, camera does not automatically reboot.Expected behavior is for majestic to feed the watchdog, and if majestic crashes, watchdog timer would expire and reset cpu, forcing host reboot.