Skip to content

Conversation

hshpy
Copy link
Contributor

@hshpy hshpy commented Sep 5, 2025

No description provided.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements zip slip security protection by preventing path traversal attacks during archive decompression. The changes add validation to ensure extracted files cannot escape the intended output directory through malicious path names containing "../" sequences.

  • Replaces standard library path with filepath for proper OS-specific path handling
  • Adds path validation checks in decompression functions to prevent zip slip attacks
  • Introduces utility function usage for path cleaning and normalization

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

KirCute
KirCute previously approved these changes Sep 8, 2025
ILoveScratch2
ILoveScratch2 previously approved these changes Sep 8, 2025
@ILoveScratch2
Copy link
Member

不只是ZIP,其他格式也要修
比如:
archives_gzip.tar.gz

@hshpy hshpy dismissed stale reviews from ILoveScratch2 and KirCute via 54851c0 September 8, 2025 12:59
@hshpy
Copy link
Contributor Author

hshpy commented Sep 8, 2025

不只是ZIP,其他格式也要修 比如: archives_gzip.tar.gz

已添加,其它格式待测试

@ILoveScratch2 ILoveScratch2 merged commit c1d03c5 into OpenListTeam:main Sep 15, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in OpenList开发计划 Sep 15, 2025
@hshpy hshpy deleted the fix9 branch September 15, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants