Fixes to PUA and related Usrloc-changes #3608
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 03690e9.
|
@LarryLaffer-dev , thanks for your contribution. In order to be properly evaluated, you will need to break it into smaller pieces, which can be digested by itself. Like please open a separate PR for each pua_usrloc crash, we can understand the issue and the fix (without mixes from other crashes). As for the extensions, similar, please create a dedicated PR for each of them. Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes some crashes identified in the pua_usrloc module. In order for this module to provide the relevant information, Usrloc needs to store additional information (Parameters from Contact), which is now incorporated as well.
Details
Since the body may become large, the PR introduces a variable String-Buffer to facilitate larger results. Since the result should include the params of the Contact-Header, the according Params are retrieved (and stored) from usrloc.
Solution
I did not fully test the clustering and DB-operations of data yet.
Compatibility
This PR changes the schema of the location DB (added location column), so it is not backward compatible.