Ignore extra headers in MSRP #3716
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue if MSRP messages container other/non-required headers.
Details
If an MSRP message contains a header such as Content-Disposition, which is a recognized header, the message will get rejected with "ERROR:core:handle_mi_request: Invalid parameters". This is a valid header in an MSRP message as described in RFC 4975, section 9.
Solution
This fix moves the "default" switch case to be grouped with HDR_OTHER_T instead of HDR_ERROR_T and allows for the continued processing of the message.
Compatibility
This should not cause any issues with existing code unless it was relying on a message with other headers being rejected.
Closing issues