Free Null - Bug Fix #896
Open
Free Null - Bug Fix #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed that the tls_session_init() function only initializes the KS_PRIMARY key and not the KS_LAME_DUCK key and the tls_session_free() function will free ALL keys always. This is a mis-match in the init-free callback chain which can potentially cause problems. For example, if a client connects and then disconnects before the renegotiation window, the lame duck key may not be initialized and then the key_state_free() function will be called which will then call the free_buf() function last (this may likely only operate on a NULL pointer and may indeed also check for this but it is not considered a good quality code path and practice in general to have)! Thanks.