Skip to content

fix: send pipeline in intent metrics #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

fix: send pipeline in intent metrics #689

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c1049a
fix: send pipeline in intent metrics
JarbasAl Jun 5, 2025
a35abc4
include version string
JarbasAl Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 23 additions & 16 deletions ovos_core/intent_services/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,32 +14,34 @@
#

import json
import warnings
import time
import warnings
from collections import defaultdict
from typing import Tuple, Callable, Union, List

import requests
from ovos_config.config import Configuration
from ovos_config.locale import get_valid_languages

from ocp_pipeline.opm import OCPPipelineMatcher
from ovos_adapt.opm import AdaptPipeline
from ovos_bus_client.message import Message
from ovos_bus_client.session import SessionManager
from ovos_bus_client.util import get_message_lang
from ovos_commonqa.opm import CommonQAService
from ovos_core.intent_services.converse_service import ConverseService
from ovos_core.intent_services.fallback_service import FallbackService
from ovos_core.intent_services.stop_service import StopService
from ovos_core.transformers import MetadataTransformersService, UtteranceTransformersService, IntentTransformersService
from ovos_persona import PersonaService
from ovos_plugin_manager.templates.pipeline import PipelineMatch, IntentHandlerMatch
from ovos_utils.lang import standardize_lang_tag
from ovos_utils.log import LOG, log_deprecation, deprecated
from ovos_utils.metrics import Stopwatch
from ovos_utils.thread_utils import create_daemon
from padacioso.opm import PadaciosoPipeline as PadaciosoService
from ovos_core.version import OVOS_VERSION_STR

from ocp_pipeline.opm import OCPPipelineMatcher
from ovos_adapt.opm import AdaptPipeline
from ovos_commonqa.opm import CommonQAService
from ovos_config.config import Configuration
from ovos_config.locale import get_valid_languages
from ovos_core.intent_services.converse_service import ConverseService
from ovos_core.intent_services.fallback_service import FallbackService
from ovos_core.intent_services.stop_service import StopService
from ovos_core.transformers import MetadataTransformersService, UtteranceTransformersService, IntentTransformersService
from ovos_persona import PersonaService

# TODO - to be dropped once pluginified
# just a placeholder during alphas until https://github.com/OpenVoiceOS/ovos-core/pull/570
Expand Down Expand Up @@ -386,7 +388,8 @@ def _emit_match_message(self, match: Union[IntentHandlerMatch, PipelineMatch], m
create_daemon(self._upload_match_data, (match.utterance,
match.skill_id,
lang,
match.match_data))
match.match_data,
sess.pipeline))

# Launch skill if not handled by the match function
elif isinstance(match, IntentHandlerMatch) and match.match_type:
Expand All @@ -399,7 +402,8 @@ def _emit_match_message(self, match: Union[IntentHandlerMatch, PipelineMatch], m
create_daemon(self._upload_match_data, (match.utterance,
match.match_type,
lang,
match.match_data))
match.match_data,
sess.pipeline))

if reply is not None:
reply.data["utterance"] = match.utterance
Expand Down Expand Up @@ -429,10 +433,11 @@ def _emit_match_message(self, match: Union[IntentHandlerMatch, PipelineMatch], m
create_daemon(self._upload_match_data, (match.utterance,
"complete_intent_failure",
lang,
match.match_data))
match.match_data,
sess.pipeline))

@staticmethod
def _upload_match_data(utterance: str, intent: str, lang: str, match_data: dict):
def _upload_match_data(utterance: str, intent: str, lang: str, match_data: dict, pipeline: List[str]):
"""if enabled upload the intent match data to a server, allowing users and developers
to collect metrics/datasets to improve the pipeline plugins and skills.

Expand All @@ -452,7 +457,9 @@ def _upload_match_data(utterance: str, intent: str, lang: str, match_data: dict)
"utterance": utterance,
"intent": intent,
"lang": lang,
"match_data": json.dumps(match_data, ensure_ascii=False)
"match_data": json.dumps(match_data, ensure_ascii=False),
"pipeline": "|".join(pipeline),
"core_version": OVOS_VERSION_STR
}
for url in endpoints:
try:
Expand Down
Loading