Skip to content

Conversation

ericnordelo
Copy link
Member

@ericnordelo ericnordelo commented Sep 17, 2025

Fixes #1462

PR Checklist

  • Tests
  • Documentation
  • Added entry to CHANGELOG.md
  • Tried the feature on a public network

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR decouples the versioning of utility packages from the main umbrella package, allowing them to be versioned independently. It fixes issue #1462 by establishing separate version tracking for openzeppelin_utils and openzeppelin_interfaces packages.

  • Removed workspace version inheritance for utils package and set explicit version
  • Updated interfaces package to use alpha versioning
  • Added dedicated changelog files for both packages
  • Updated documentation to reflect the new independent versioning approach

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/utils/Scarb.toml Removes workspace version inheritance and sets explicit version 3.1.0-alpha.0
packages/utils/CHANGELOG.md Adds new changelog documenting the version decoupling change
packages/interfaces/Scarb.toml Updates version from 2.1.0 to 2.1.0-alpha.0
packages/interfaces/CHANGELOG.md Adds new changelog documenting interface migration
docs/modules/ROOT/pages/utils/_common.adoc Adds version variables for both packages
docs/modules/ROOT/pages/index.adoc Updates versioning documentation and uses template variables
docs/modules/ROOT/pages/api/utilities.adoc Adds versioning notice and includes common variables

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

github-actions bot commented Sep 17, 2025

🧪 Cairo Contract Size Benchmark Diff

BYTECODE SIZE (felts) (limit: 81,920 felts)

No changes in felts.

SIERRA CONTRACT CLASS SIZE (bytes) (limit: 4,089,446 bytes)

No changes in bytes.

This comment was generated automatically from benchmark diffs.

Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (34d08e3) to head (d55344a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1531   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files          82       83    +1     
  Lines        2272     2272           
=======================================
  Hits         2099     2099           
  Misses        173      173           
Files with missing lines Coverage Δ
packages/account/src/account.cairo 91.30% <ø> (ø)
packages/account/src/eth_account.cairo 89.18% <ø> (ø)
packages/account/src/extensions/src9/src9.cairo 95.00% <ø> (ø)
packages/account/src/utils.cairo 100.00% <ø> (ø)
packages/governance/src/governor/governor.cairo 91.30% <ø> (ø)
packages/governance/src/votes/votes.cairo 91.93% <ø> (ø)
packages/token/src/erc20/erc20.cairo 98.03% <ø> (ø)
packages/utils/src/execution.cairo 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34d08e3...d55344a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@immrsd immrsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Let's wait with merging the PR till the next sync to make the final decision on the version of utils package

@ericnordelo ericnordelo merged commit c73ef18 into main Oct 8, 2025
8 checks passed
@ericnordelo ericnordelo deleted the feat/decouple-utils-package-#1462 branch October 8, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple interfaces and utils package versioning
2 participants