-
Notifications
You must be signed in to change notification settings - Fork 391
Decouple utils and fix versioning #1531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR decouples the versioning of utility packages from the main umbrella package, allowing them to be versioned independently. It fixes issue #1462 by establishing separate version tracking for openzeppelin_utils
and openzeppelin_interfaces
packages.
- Removed workspace version inheritance for utils package and set explicit version
- Updated interfaces package to use alpha versioning
- Added dedicated changelog files for both packages
- Updated documentation to reflect the new independent versioning approach
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
packages/utils/Scarb.toml | Removes workspace version inheritance and sets explicit version 3.1.0-alpha.0 |
packages/utils/CHANGELOG.md | Adds new changelog documenting the version decoupling change |
packages/interfaces/Scarb.toml | Updates version from 2.1.0 to 2.1.0-alpha.0 |
packages/interfaces/CHANGELOG.md | Adds new changelog documenting interface migration |
docs/modules/ROOT/pages/utils/_common.adoc | Adds version variables for both packages |
docs/modules/ROOT/pages/index.adoc | Updates versioning documentation and uses template variables |
docs/modules/ROOT/pages/api/utilities.adoc | Adds versioning notice and includes common variables |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
🧪 Cairo Contract Size Benchmark DiffBYTECODE SIZE (felts) (limit: 81,920 felts)No changes in felts. SIERRA CONTRACT CLASS SIZE (bytes) (limit: 4,089,446 bytes)No changes in bytes. This comment was generated automatically from benchmark diffs. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1531 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 82 83 +1
Lines 2272 2272
=======================================
Hits 2099 2099
Misses 173 173
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Let's wait with merging the PR till the next sync to make the final decision on the version of utils
package
Fixes #1462
PR Checklist