-
Notifications
You must be signed in to change notification settings - Fork 186
refactor(app): Reformat robot settings tab to match protocol set up and remove canceled run banner #19837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration flow (#19744) # Overview Waste chute warnings are now separate pages during 96ch calibration flow. This was changed because there are reports that the smaller warnings on other pages were easy to miss and caused collisions in the field. `NOTE`: No images for these pages per this slack conversation: [slack convo](https://opentrons.slack.com/archives/C06M9F26YGH/p1759867096134759) ## Test Plan and Hands on Testing - Tested calibration flow on a robot with a 96ch with the deck configured with/without the waste chute to confirm the page flow - Tested `Detach Left Pipette and Attach 96-Channel Pipette` flow - Test 96ch detach flow to confirm page flow ## Changelog - Changed warning banner on probe page to only display when a 96ch is attached and not a waste chute <img width="856" height="627" alt="Screenshot 2025-10-16 at 4 50 44 PM" src="https://github.com/user-attachments/assets/2821d1da-ce38-4c45-b0a3-7f349dc756e3" /> Set up page includes a screwdriver because it is needed to remove the waste chute <img width="742" height="437" alt="Screenshot 2025-10-07 at 3 03 20 PM" src="https://github.com/user-attachments/assets/46a1689b-7f39-4f2d-a0e0-84c77ce25720" /> Remove waste chute page <img width="741" height="446" alt="Screenshot 2025-10-17 at 12 18 31 PM" src="https://github.com/user-attachments/assets/6077fa52-3779-4203-8043-197b62590fe3" /> Re-attach waste chute page <img width="751" height="453" alt="Screenshot 2025-10-16 at 4 53 27 PM" src="https://github.com/user-attachments/assets/c3755f10-9bef-482d-84a0-a551ba54e9b9" /> Closes EXEC-1100
…ls (#19833) # Overview When `useCommandTypeSummaries.test.tsx` fails, it emits the error ``` AssertionError: expected 'Unknown' not to be 'Unknown' ``` which is not very helpful for explaining what's wrong. (AUTH-2353) This PR adds the offending command to the error message: ``` captureImage: expected 'Unknown' not to be 'Unknown' ``` which is slightly more informative. ## Test Plan and Hands on Testing Ran `yarn vitest` locally. ## Risk assessment Low.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Match robot settings page to protocol set up
Remove canceled run banner
Test Plan and Hands on Testing
Changelog
Review requests
Closes EXEC-1860
Closes EXEC-1979