Skip to content

Conversation

@rclarke0
Copy link
Contributor

@rclarke0 rclarke0 commented Oct 20, 2025

Overview

Match robot settings page to protocol set up

Remove canceled run banner

Test Plan and Hands on Testing

  • Smoke checked robot with canceled run and simulated app to look at robot settings page

Changelog

Screenshot 2025-10-20 at 10 23 04 AM

Review requests

  • Each page on the settings tab looks like the text is formatted differently. Probably want to do a follow up PR to fix that at some point
Screenshot 2025-10-20 at 10 27 33 AM Screenshot 2025-10-20 at 10 27 27 AM

Closes EXEC-1860
Closes EXEC-1979

@rclarke0 rclarke0 requested a review from a team as a code owner October 20, 2025 14:28
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 0% with 747 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.15%. Comparing base (1abef58) to head (d702ee5).
⚠️ Report is 6 commits behind head on edge.

Files with missing lines Patch % Lines
...tteWizardFlows/getPipetteWizardStepsForProtocol.ts 0.00% 91 Missing ⚠️
app/src/organisms/PipetteWizardFlows/utils.tsx 0.00% 72 Missing ⚠️
...anisms/PipetteWizardFlows/getPipetteWizardSteps.ts 0.00% 60 Missing ⚠️
.../src/pages/Desktop/Devices/RobotSettings/index.tsx 0.00% 58 Missing ⚠️
app/src/pages/Desktop/StepDetailViewer/index.tsx 0.00% 53 Missing ⚠️
.../src/secondary-windows/step-detail-viewer/index.ts 0.00% 45 Missing ⚠️
.../organisms/PipetteWizardFlows/RemoveWasteChute.tsx 0.00% 41 Missing ⚠️
...cols/ProtocolVisualization/VisualizerContainer.tsx 0.00% 35 Missing ⚠️
app-shell/src/secondary-windows/index.ts 0.00% 34 Missing ⚠️
...ProtocolRun/ProtocolRunHeader/DisplayRunStatus.tsx 0.00% 34 Missing ⚠️
... and 17 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #19837      +/-   ##
==========================================
- Coverage   25.61%   25.15%   -0.46%     
==========================================
  Files        3513     3515       +2     
  Lines      295525   293306    -2219     
  Branches    39620    39574      -46     
==========================================
- Hits        75692    73775    -1917     
+ Misses     219807   219506     -301     
+ Partials       26       25       -1     
Flag Coverage Δ
step-generation 5.43% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app-shell/src/secondary-windows/types.ts 100.00% <ø> (ø)
...rBannerContainer/getShowGenericRunHeaderBanners.ts 0.00% <ø> (ø)
...otocolRunHeader/RunHeaderBannerContainer/index.tsx 0.00% <ø> (ø)
...nHeader/RunHeaderContent/RunHeaderSectionLower.tsx 0.00% <ø> (ø)
app/src/organisms/PipetteWizardFlows/types.ts 100.00% <ø> (ø)
app/src/redux/shell/types.ts 100.00% <ø> (ø)
app/src/redux/types.ts 0.00% <ø> (ø)
...lRunHeader/RunHeaderContent/ActionButton/index.tsx 0.00% <0.00%> (ø)
...ktop/ProtocolVisualization/StepDetailContainer.tsx 0.00% <0.00%> (ø)
...pages/Desktop/Devices/ProtocolRunDetails/index.tsx 0.00% <0.00%> (ø)
... and 24 more

... and 278 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rclarke0 and others added 5 commits October 20, 2025 11:17
…ration flow (#19744)

# Overview

Waste chute warnings are now separate pages during 96ch calibration
flow.

This was changed because there are reports that the smaller warnings on
other pages were easy to miss and caused collisions in the field.

`NOTE`: No images for these pages per this slack conversation: [slack
convo](https://opentrons.slack.com/archives/C06M9F26YGH/p1759867096134759)

## Test Plan and Hands on Testing

- Tested calibration flow on a robot with a 96ch with the deck
configured with/without the waste chute to confirm the page flow
- Tested `Detach Left Pipette and Attach 96-Channel Pipette` flow
- Test 96ch detach flow to confirm page flow

## Changelog
- Changed warning banner on probe page to only display when a 96ch is
attached and not a waste chute
<img width="856" height="627" alt="Screenshot 2025-10-16 at 4 50 44 PM"
src="https://github.com/user-attachments/assets/2821d1da-ce38-4c45-b0a3-7f349dc756e3"
/>

Set up page includes a screwdriver because it is needed to remove the
waste chute
<img width="742" height="437" alt="Screenshot 2025-10-07 at 3 03 20 PM"
src="https://github.com/user-attachments/assets/46a1689b-7f39-4f2d-a0e0-84c77ce25720"
/>
Remove waste chute page
<img width="741" height="446" alt="Screenshot 2025-10-17 at 12 18 31 PM"
src="https://github.com/user-attachments/assets/6077fa52-3779-4203-8043-197b62590fe3"
/>

Re-attach waste chute page
<img width="751" height="453" alt="Screenshot 2025-10-16 at 4 53 27 PM"
src="https://github.com/user-attachments/assets/c3755f10-9bef-482d-84a0-a551ba54e9b9"
/>


Closes EXEC-1100
…ls (#19833)

# Overview

When `useCommandTypeSummaries.test.tsx` fails, it emits the error
```
AssertionError: expected 'Unknown' not to be 'Unknown'
```
which is not very helpful for explaining what's wrong. (AUTH-2353)

This PR adds the offending command to the error message:
```
captureImage: expected 'Unknown' not to be 'Unknown'
```
which is slightly more informative.

## Test Plan and Hands on Testing

Ran `yarn vitest` locally.

## Risk assessment

Low.
@rclarke0 rclarke0 closed this Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants