feat: allow showing coordinates for objectives with hints #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a config option to allow showing coordinates for objectives that already have some hints revealed. This applies to both the bingo card, and completion messages. The objective coordinate will always be shown when no hint has been revealed yet. Fixes OvercastCommunity#10
|
No need for config, this should always be a thing (consistent with how it is right now for hidden objectives) |
|
I think having an option to disable this is desirable, for example for teasers. Showing the coordinate for a teaser "objective" (something like "Get ready! (C3)") isn't really it IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a config option to allow showing coordinates for objectives that already have some hints revealed. This applies to both the bingo card, and completion messages.
The objective coordinate will always be shown when no hint has been revealed yet.
Fixes #10