Support item matcher in itemmods #1556
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for item-mods to have a
matcher
subelement formatch
which is an item matcher definition, such as those found in holding/carrying filters or replace-item/enchant-item actions.eg:
Do note: item-mods still apply JUST ONCE whenever the item is first observed (eg: when a chest is opened, or when the kit is created), so things like trying to modify the item when it gets to a certain durability, or if it gets enchanted with something after the fact is not and will not be supported.
This is more of a prototype because it was requested by a mapdev, but i'm not convinced this actually solves their intended use-case which was modifying punch bows in chests, as itemmods can only add not remove stuff. Also not convinced on the xml name for it, but we can't really use
material
oritem
as either of those are already interpreted as being materials for the material matcher.