Skip to content

Update to Php8.5-compatible Dompdf #4659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

Update to Php8.5-compatible Dompdf #4659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 1 addition & 29 deletions src/PhpSpreadsheet/Writer/Pdf/Dompdf.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,43 +44,15 @@ public function save($filename, int $flags = 0): void
$orientation = ($orientation == 'L') ? 'landscape' : 'portrait';

// Create PDF
$restoreHandler = false;
if (PHP_VERSION_ID >= self::$temporaryVersionCheck) {
// @codeCoverageIgnoreStart
set_error_handler(self::specialErrorHandler(...));
$restoreHandler = true;
// @codeCoverageIgnoreEnd
}
$pdf = $this->createExternalWriterInstance();
$pdf->setPaper($paperSize, $orientation);

$pdf->loadHtml($this->generateHTMLAll());
$pdf->render();

// Write to file
fwrite($fileHandle, $pdf->output() ?? '');
fwrite($fileHandle, $pdf->output());

if ($restoreHandler) {
restore_error_handler(); // @codeCoverageIgnore
}
parent::restoreStateAfterSave();
}

protected static int $temporaryVersionCheck = 80500;

/**
* Temporary handler for Php8.5 waiting for Dompdf release.
*
* @codeCoverageIgnore
*/
public function specialErrorHandler(int $errno, string $errstr, string $filename, int $lineno): bool
{
if ($errno === E_DEPRECATED) {
if (preg_match('/canonical|imagedestroy|http_get_last_response_headers|Using null as an array offset/', $errstr) === 1) {
return true;
}
}

return false; // continue error handling
}
}